Skip to content

fix: title for issues #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexanderBrevig merged 1 commit into from
Mar 8, 2024
Merged

fix: title for issues #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ This is a tool for getting link suggestions while writing READMEs and GitHub Wik

Use this LSP in conjunction with some other Markdown LSP if you want gotoDefinition et.al. This LSP only focuses on adding autocomplete to

* [x] `#` Issues and PRs
* [x] `[` Public Wiki Pages
* [x] `:` Organizations / Owners
* [x] `/` Repositories (yours and the orgs you are part of, no global search yet)
* [x] `@` Organization Members
- [x] `#` Issues and PRs
- [x] `[` Public Wiki Pages
- [x] `:` Organizations / Owners
- [x] `/` Repositories (yours and the orgs you are part of, no global search yet)
- [x] `@` Organization Members

[Issues](https://github.com/github-language-server/github-lsp/issues) and [PRs](https://github.com/github-language-server/github-lsp/pulls) are very welcome!

Expand Down Expand Up @@ -47,8 +47,8 @@ You can now configure your editor to use this LSP on `stdio`.

### `#` trigger

[#1](https://github.com/github-language-server/github-lsp/issues/1)
[#2](https://github.com/github-language-server/github-lsp/issues/2)
[#1: Example open issue](https://github.com/github-language-server/github-lsp/issues/1)
[#2: Example closed issue](https://github.com/github-language-server/github-lsp/issues/2)

### `@` trigger

Expand Down
3 changes: 2 additions & 1 deletion src/gh/issue.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,14 @@ impl GetLabel for Issue {
impl GetEdit for Issue {
fn get_edit(&self) -> String {
let id = self.number;
let title = &self.title;
let url = self
.url
.to_string()
.replace("api.", "")
.replace("repos/", "");
//TODO: cleanup & consider just printing the full URL and let GitHub format it
format!("[#{id}]({url})")
format!("[#{id}: {title}]({url})")
}
}
impl GetDetail for Issue {
Expand Down