Skip to content

Url for PRs are wrong #16

Open
Open
Url for PRs are wrong#16
Labels
enhancementNew feature or requestgood-first-issueA good way to get started

Description

@AlexanderBrevig
AlexanderBrevig
opened on Mar 4, 2024

Currently the LSP will generate an /issues/ URL when completing a PR.

This is because we're using the issues API.
https://github.com/AlexanderBrevig/github-lsp/blob/e5b99c94f233c93fec3aed1936e81218fc816c57/src/backend.rs#L260-L267

Maybe we should use search and filter on is:issue and is:pr, then decorate the cached object in
https://github.com/AlexanderBrevig/github-lsp/blob/e5b99c94f233c93fec3aed1936e81218fc816c57/src/backend.rs#L20

Activity

  1. AlexanderBrevig
    added
    bugSomething isn't working
    good-first-issueA good way to get started
    enhancementNew feature or request
    and removed
    bugSomething isn't working
    on Mar 4, 2024

  2. AlexanderBrevig commented on Mar 4, 2024

    @AlexanderBrevig
    AlexanderBrevig
    on Mar 4, 2024
    MemberAuthor

    Not marking this as bug, since it is working. GitHub rewrites the URL and points to the correct PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestgood-first-issueA good way to get started

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions