Repository navigation
fixed startup cost - #175
Merged
Merged
Conversation
tomellm
requested review from
LanderTuyteleersXplore,
YorbenAudenaert,
bavodaniels,
gerd-goemans and
henrybley
as code owners
May 30, 2024 09:17
henrybley
approved these changes
May 30, 2024
henrybley
left a comment
henrybley
left a comment
Contributor
There was a problem hiding this comment.
lgtm lets see how it works
tomellm
force-pushed
the
tom/#174-startup-cost
branch
from
May 30, 2024 10:09
7713fd7 to
54f51c6
Compare
Contributor
Author
|
@henrybley I found other things that I can fix, it was just a single function that wasn't testable |
tomellm
force-pushed
the
tom/#174-startup-cost
branch
from
May 30, 2024 10:39
54f51c6 to
bd9544e
Compare
Before when big spikes of requests would happen the ratelimiter would raise the level so high that nothing would run anymore and then slowly drop it back down where it would then jump back up. This would take quite a while to stabilize until all the caches were up to date and the requests would diminish. Now the ratelimiter only raises the level by one at a time makeing it less sensitive to very short and sudden spikes in requests. Also changed some logging to have a clearer view into what is happening.
tomellm
force-pushed
the
tom/#174-startup-cost
branch
from
May 30, 2024 10:57
bd9544e to
d547b2f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#174 Before when big spikes of requests would happen the ratelimiter would raise the level so high that nothing would run anymore and then slowly drop it back down where it would then jump back up. This would take quite a while to stabilize until all the caches were up to date and the requests would diminish.
Now the ratelimiter only raises the level by one at a time makeing it less sensitive to very short and sudden spikes in requests.
Also changed some logging to have a clearer view into what is happening.