Repository navigation
unstucking the rate limit status - #172
Merged
Merged
Conversation
tomellm
requested review from
LanderTuyteleersXplore,
YorbenAudenaert,
bavodaniels,
gerd-goemans and
henrybley
as code owners
May 29, 2024 12:32
Before the problem was that the status could only update when requests where beeing made meaning that in the case where all requests were stopped because the status changed to CRITICAL for example it would never update. Now I have created a control task that runs every so often (default 5 mins) and checks if requests have been made in that timeframe. If that is not the case then it lowers the status by one. (Consider that since the status is an optional and empty in the case of a limit await this lowering by one might actually not do anything)
tomellm
force-pushed
the
tom/#170-unstucking-ratelimitstate
branch
from
May 29, 2024 13:09
cb316bf to
ee1f64c
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#170 Before the problem was that the status could only update when requests where beeing made meaning that in the case where all requests were stopped because the status changed to CRITICAL for example it would never update.
Now I have created a control task that runs every so often (default 5 mins) and checks if requests have been made in that timeframe. If that is not the case then it lowers the status by one. (Consider that since the status is an optional and empty in the case of a limit await this lowering by one might actually not do anything)