Repository navigation
fixed selfhosted runner os parsing error - #171
Merged
Merged
Conversation
tomellm
requested review from
LanderTuyteleersXplore,
YorbenAudenaert,
bavodaniels,
gerd-goemans and
henrybley
as code owners
May 29, 2024 10:58
tomellm
changed the title
henrybley
requested changes
May 29, 2024
The os string returned by the Github api turned out to be more unpredictable then expected. This meant that a more complex setup was needed to convert the os string to the OperatingSystem enum. Converting the string to enum works by trying to find any of a list of value in the returned os string. This list can be extended from the application.yaml through the APP_GITHUB_<OS>_SELFHOSTED_RUNNER_OS_KEYWORDS environemnt variable. Additionally, instead of throwing an Exception when the parsing didn't succeed I added a UNKNOWN variant to the enum and log the os string for later reference.
tomellm
force-pushed
the
tom/#166-selfhosted-runner-os
branch
from
May 29, 2024 12:38
8e365aa to
62bbf93
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#166 The os string returned by the Github api turned out to be more unpredictable then expected. This meant that a more complex setup was needed to convert the os string to the
OperatingSystemenum.Converting the string to enum works by trying to find any of a list of value in the returned os string. This list can be extended from the
application.yamlthrough theAPP_GITHUB_<OS>_SELFHOSTED_RUNNER_OS_KEYWORDSenvironemnt variable.Additionally, instead of throwing an Exception when the parsing didn't succeed I added a
UNKNOWNvariant to the enum and log the os string for later reference.