Repository navigation
#144 Create feature toggles to enable/disable metrics - #147
Merged
Merged
Conversation
henrybley
requested review from
LanderTuyteleersXplore,
YorbenAudenaert,
bavodaniels,
gerd-goemans and
tomellm
as code owners
May 23, 2024 12:15
tomellm
approved these changes
May 23, 2024
tomellm
left a comment
tomellm
left a comment
Contributor
There was a problem hiding this comment.
just check the two comments, otherwise looks good to me
Comment on lines
+6
to
+12
| export APP_GITHUB_APPLICATION_PEM="" | ||
| export EXPORTER_JOBS_FEATURE=false | ||
| export EXPORTER_WORKFLOW_RUNS_FEATURE=false | ||
| export EXPORTER_WORKFLOW_RUN_BUILD_TIMES_FEATURE=false | ||
| export EXPORTER_SELF_HOSTED_RUNNERS_EXPORTER=false | ||
| export EXPORTER_REPOSITORIES_FEATURE=false | ||
| export EXPORTER_PULL_REQUESTS_FEATURE=false No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
yeah I prefer them all off
Comment on lines
+34
to
+43
| EXPORTER_JOBS_FEATURE: | ||
| enabled: ${EXPORTER_JOBS_FEATURE:false} | ||
| EXPORTER_WORKFLOW_RUNS_FEATURE: | ||
| enabled: ${EXPORTER_WORKFLOW_RUNS_FEATURE:false} | ||
| EXPORTER_SELF_HOSTED_RUNNERS_EXPORTER: | ||
| enabled: ${EXPORTER_SELF_HOSTED_RUNNERS_EXPORTER:false} | ||
| EXPORTER_REPOSITORIES_FEATURE: | ||
| enabled: ${EXPORTER_REPOSITORIES_FEATURE:false} | ||
| EXPORTER_PULL_REQUESTS_FEATURE: | ||
| enabled: ${EXPORTER_PULL_REQUESTS_FEATURE:false} |
Contributor
There was a problem hiding this comment.
still wonder if everything should be turned off or if maybe the most basic ones like Repositories and WorkflowRuns should be turned on?
Contributor
Author
There was a problem hiding this comment.
again yeah I'd rather have all off and let the end user decide which features to turn on
implemented the togglz library to be able to turn on/off features based off .env variables
henrybley
force-pushed
the
henry/toggle-features
branch
from
May 23, 2024 12:26
fcee066 to
53adde3
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implemented the togglz library to be able to turn on/off features based off .env variables