Skip to content

Fix asciidoc compatibility issues - #926

Merged
peff merged 1 commit into
git:masterfrom
jnavila:fix_asciidoc_compat
Jan 20, 2017
Merged

peff merged 1 commit into
git:masterfrom
jnavila:fix_asciidoc_compat

Conversation

@jnavila

@jnavila jnavila commented Jan 20, 2017

Copy link
Copy Markdown
Contributor

Some parts of asciidoc are not rendered correctly by asciidoctor
unless a compat-mode option is enabled.

This fixes #925

Some parts of asciidoc are not rendered correctly by asciidoctor
unless a `compat-mode` option is enabled.
@peff

peff commented Jan 20, 2017

Copy link
Copy Markdown
Member

Hmm. That makes me wonder if we should be setting the same flag for manpage builds. I don't think that needs to be part of this PR, though.

@peff
peff merged commit c27833e into git:master Jan 20, 2017
@peff

peff commented Jan 20, 2017

Copy link
Copy Markdown
Member

Merged, deployed, and new versions are building (which annoyingly have to be kicked off in a shell for loop after digging the set of language codes out of the database; there's no "I changed the config; rebuild everything" part of the task).

@jnavila

jnavila commented Jan 20, 2017

Copy link
Copy Markdown
Contributor Author

This could be surely done by mixing the sha-1 of the book with the one of the script.

@jnavila
jnavila deleted the fix_asciidoc_compat branch January 20, 2017 21:17
@peff

peff commented Jan 20, 2017

Copy link
Copy Markdown
Member

This could be surely done by mixing the sha-1 of the book with the one of the script.

Yeah, I had that thought, too, but it's hard to cover all cases (e.g., asciidoctor gem gets bumped). I don't mind kicking off a rebuild-all job. It's just that I had to open a ruby console do a database query to get the set of codes.

OTOH, long "heroku run rake ..." jobs seem to get killed after a few minutes (I think heroku limits the time). So the right rake task is probably to just mark all of the entries as invalid in the database, and then they can be rebuilt manually, or at the next cronjob.

@jnavila

jnavila commented Jan 21, 2017

Copy link
Copy Markdown
Contributor Author

OK. I see. Just adding a target to rake to reset all the book.ebook_html in DB would do the trick then.

@peff

peff commented Jan 21, 2017

Copy link
Copy Markdown
Member

Yeah, added in 1b9c2aa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect book rendering

2 participants