Repository navigation
Fix asciidoc compatibility issues - #926
Conversation
Some parts of asciidoc are not rendered correctly by asciidoctor unless a `compat-mode` option is enabled.
|
Hmm. That makes me wonder if we should be setting the same flag for manpage builds. I don't think that needs to be part of this PR, though. |
|
Merged, deployed, and new versions are building (which annoyingly have to be kicked off in a shell for loop after digging the set of language codes out of the database; there's no "I changed the config; rebuild everything" part of the task). |
|
This could be surely done by mixing the sha-1 of the book with the one of the script. |
Yeah, I had that thought, too, but it's hard to cover all cases (e.g., asciidoctor gem gets bumped). I don't mind kicking off a rebuild-all job. It's just that I had to open a ruby console do a database query to get the set of codes. OTOH, long "heroku run rake ..." jobs seem to get killed after a few minutes (I think heroku limits the time). So the right rake task is probably to just mark all of the entries as invalid in the database, and then they can be rebuilt manually, or at the next cronjob. |
|
OK. I see. Just adding a target to rake to reset all the book.ebook_html in DB would do the trick then. |
|
Yeah, added in 1b9c2aa. |
Some parts of asciidoc are not rendered correctly by asciidoctor
unless a
compat-modeoption is enabled.This fixes #925