[jdeolive]

Pull request for #25.

[ktoso]

Hey, I've merged your pull request - will release stable today in the evening :-)

[jdeolive]

Great! Thanks for the quick response. And for the very useful plugin!

[ktoso]

Released into sonatype repository as https://oss.sonatype.org/content/repositories/releases/pl/project13/maven/git-commit-id-plugin/2.0.4/
It will soon automatically be synced into maven central :-)

There's going to be a bit of code cleanup in 2.1 I think, but until 2.1.x you're safe with this and the upcoming versions without any configuration changes :-)

Cheers and thanks for using the plugin :-)

[jdeolive]

Perfect. Come to think of it though my patch included an updated README with the new configuration parameter, but the plugin config references the 1.9 version of the plugin. I imagine this might lead to a few issue reports :) Perhaps we should note in the comment it was added post 2.0.4?

[ktoso]

Hm, hm... I'll update the readme with info about when this option was added and bump the used version in the example :-)
Thanks for bringing it up!

[andrewfinnell]

This doesn't seem to work for me. If I am missing a .git directory and I specify false I get a NPE.

[ERROR] Failed to execute goal pl.project13.maven:git-commit-id-plugin:2.1.0:revision (default) on project xx: Execution default of goal pl.project13.maven:git-commit-id-plugin:2.1.0:revision failed. NullPointerException

[andrewfinnell]

This should be reopened. 2.1.0 easily fails if you run this plugin in a directory that is not in a git repo.

[ktoso]

I saw the first comment - no need to ping after 5h again :-) Reopening.
Seems we don't have a test for this case.

[ktoso]

Continue discussion here -> #25 Can't reopen this ticket (merge request).