Skip to content

Unquote abs_path before processing - #53255

Merged
Swatinem merged 2 commits into
masterfrom
swatinem/unquote-abs_path
Jul 20, 2023
Merged

Swatinem merged 2 commits into
masterfrom
swatinem/unquote-abs_path

Conversation

@Swatinem

Copy link
Copy Markdown
Contributor

We have observed customers that have special characters in their file name, and the SDK reports those as url-encoded urls. We need to decode this before we go into processing, so we query for and find the correct uploaded files.

We have observed customers that have special characters in their file name, and the SDK reports those as url-encoded urls. We need to decode this before we go into processing, so we query for and find the correct uploaded files.
@Swatinem Swatinem self-assigned this Jul 20, 2023
@Swatinem
Swatinem requested a review from a team July 20, 2023 08:51
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 20, 2023
@codecov

codecov Bot commented Jul 20, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #53255 (617a477) into master (a35e3e0) will decrease coverage by 3.87%.
The diff coverage is 83.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #53255      +/-   ##
==========================================
- Coverage   79.51%   75.64%   -3.87%     
==========================================
  Files        4939     4937       -2     
  Lines      207971   207926      -45     
  Branches    35478    35477       -1     
==========================================
- Hits       165368   157295    -8073     
- Misses      37565    45420    +7855     
- Partials     5038     5211     +173     
Impacted Files Coverage Δ
src/sentry/lang/javascript/processing.py 60.35% <83.33%> (+0.84%) ⬆️

... and 525 files with indirect coverage changes

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this so quickly!

@Swatinem
Swatinem enabled auto-merge (squash) July 20, 2023 09:36
@Swatinem
Swatinem merged commit 096b214 into master Jul 20, 2023
@Swatinem
Swatinem deleted the swatinem/unquote-abs_path branch July 20, 2023 10:00
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 4, 2023

This branch was successfully deployed

1 active deployment
Preview — 617a4773 Deployed Jul 20, 2023 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants