Skip to content

ref(replays): Read from the rrweb saved config to see if replay network details is setup - #48967

Merged
ryan953 merged 2 commits into
masterfrom
ryan953/48733-read-rrweb-options-event
May 15, 2023
Merged

ryan953 merged 2 commits into
masterfrom
ryan953/48733-read-rrweb-options-event

Conversation

@ryan953

@ryan953 ryan953 commented May 11, 2023 •

Copy link
Copy Markdown
Member

@ryan953
ryan953 requested a review from a team May 11, 2023 21:14
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 11, 2023
@ryan953
ryan953 requested review from billyvg and eliashussary May 11, 2023 21:14
}

export type RecordingEvent = eventWithTime;
export type RecordingOptions = customEvent<{

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm we should probably have this type defined in SDK.

@ryan953
ryan953 merged commit 7b5ef20 into master May 15, 2023
@ryan953
ryan953 deleted the ryan953/48733-read-rrweb-options-event branch May 15, 2023 17:41
volokluev pushed a commit that referenced this pull request May 30, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators May 31, 2023

This branch was successfully deployed

1 active deployment
Preview — 04d5f13c Deployed May 12, 2023 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Replay Details] Update ReplayReader.isNetworkDetailsSetup() to read from the config breadcrumb

2 participants