Repository navigation
replay(feat): Show setup instructions for Replay Network>Details req/resp bodies - #48231
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
ryan953
marked this pull request as ready for review
May 1, 2023 15:56
billyvg
reviewed
May 1, 2023
|
|
||
| isNetworkDetailsSetup = () => { | ||
| if (this._isDetailsSetup === undefined) { | ||
| // TODO(replay): there must be a better way |
ryan953
force-pushed
the
ryan953/replay-network-bodies-setup-v2
branch
from
May 2, 2023 22:06
ef78c5b to
f427633
Compare
ryan953
commented
May 2, 2023
Member
|
This replay has req/sp headers and showing the privacy message below it: |
Member
Author
@billyvg yes, I wrote a test called I could probably chop out the privacy paragraph in this case, and change the "prerequisite" header to be "Capture more custom headers"? WDYT? |
Member
Author
|
@billyvg updated and styled the "Alert to configure more headers" case (see screenshot in desc) |
billyvg
approved these changes
May 4, 2023
billyvg
left a comment
billyvg
left a comment
Member
There was a problem hiding this comment.
This looks shippable to me! We can tweak onboarding as needed
ryan953
enabled auto-merge (squash)
May 4, 2023 16:40
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the latest figma designs for the network req/resp display.
Other Cases:
Fixes #47833