Repository navigation
ref(httpx2): Drop send_default_pii support - #7830
Merged
Merged
Conversation
sentrivana
marked this pull request as ready for review
October 2, 2026 10:25
alexander-alderman-webb
approved these changes
Oct 2, 2026
Contributor
Codecov Results 📊✅ 57746 passed | ⏭️ 2727 skipped | Total: 60473 | Pass Rate: 95.49% | Execution Time: 162m 16s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2054 uncovered lines. Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.34% 90.15% -0.19%
==========================================
Files 202 185 -17
Lines 26551 20860 -5691
Branches 9856 7244 -2612
==========================================
+ Hits 23988 18806 -5182
- Misses 2563 2054 -509
- Partials 1487 1206 -281Generated by Codecov Action |
sentrivana
added a commit
that referenced
this pull request
Oct 29, 2026
### Description Removes `get_url_attributes_legacy()` from `sentry_sdk/tracing_utils.py`. Nothing on `major/3.0` calls it anymore. Its callers were the outgoing HTTP client integrations (pyreqwest, httpx, httpx2). It handled their old `send_default_pii` behavior. When #7698, #7819 and #7830 dropped `send_default_pii` support from those integrations, each one removed its calls and switched to `get_url_attributes()`. The legacy helper was left behind. **Evidence** - On `major/3.0`, `git grep -w get_url_attributes_legacy` matches only the definition. There are no callers in `sentry_sdk`, `tests`, `scripts` or `docs`. - No open PR mentions it. The function doesn't exist on `master`, so a future `master` → `major/3.0` merge can't bring it back. `get_url_attributes()` and `_apply_data_collection_filtering_to_query_string` are still used, so they stay. #### Issues n/a <!-- junior-request-attribution:start --> via **Ivana Kellyer**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AC0BTREZTS2Z%3A1793270559.842119 --> -- [View Junior Session](https://junior-prod.sentry.dev/conversations/slack%3AC0BTREZTS2Z%3A1793270559.842119) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC0BTREZTS2Z%3A1793270559.842119/?project=4510944073809921) <!-- junior-session-footer:end --> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically the same as httpx
Closes https://linear.app/getsentry/issue/PY-2862/remove-send-default-pii-from-httpx2