Repository navigation
ref(cohere): Drop send_default_pii support - #7748
Merged
alexander-alderman-webb merged 1 commit intoSep 29, 2026
Merged
Conversation
alexander-alderman-webb
marked this pull request as ready for review
September 29, 2026 09:40
Contributor
Codecov Results 📊✅ 62114 passed | ❌ 1 failed | ⏭️ 2906 skipped | Total: 65021 | Pass Rate: 95.53% | Execution Time: 175m 45s 📊 Comparison with Base Branch
➕ New Tests (1)View new tests
❌ Failed Tests
|
sentrivana
approved these changes
Sep 29, 2026
alexander-alderman-webb
deleted the
webb/cohere/drop-send-default-pii
branch
September 29, 2026 11:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
send_default_piibranches from the integration.Add the
data_collectionoption to all tests for the integration, withgen_aioptions enabled ifsend_default_piiwasTrue, andgen_aioptions disabled ifsend_default_piiwasFalse. Whensend_default_piiwas previously not supplied tosentry_init(), providedata_collection={}.Split tests that were parametrized on
send_default_piiinto two non-parametrized tests, withgen_aioptions enabled and disabled (the latter suffixed with_no_sensitive_data).Remove cases of
_data_collectiontests that are exercised by existing tests now.Closes #7588