Skip to content

ref(anthropic): Drop send_default_pii support - #7738

Merged
alexander-alderman-webb merged 2 commits into
major/3.0from
webb/anthropic/drop-send-default-pii
Sep 29, 2026
Merged

alexander-alderman-webb merged 2 commits into
major/3.0from
webb/anthropic/drop-send-default-pii

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Remove send_default_pii branches from the integration.

Add the data_collection option to all tests for the integration, with gen_ai options enabled if send_default_pii was True, and gen_ai options disabled if send_default_pii was False. When send_default_pii was previously not supplied to sentry_init(), provide data_collection={}.

Split tests that were parametrized on send_default_pii into two non-parametrized tests, with gen_ai options enabled and disabled (the latter suffixed with _no_sensitive_data).

Remove data collection specific tests, as existing tests now exercise the same code paths.

Issues

Closes #7587

Reminders

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 61843 passed | ❌ 2 failed | ⏭️ 2861 skipped | Total: 64706 | Pass Rate: 95.58% | Execution Time: 170m 28s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -72153
Passed Tests 📉 -67847
Failed Tests 📈 +2
Skipped Tests 📉 -4308

➕ New Tests (2)

View new tests
  • test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing
  • test_cache_spans_decorator
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 140605028814848

Stack Trace
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:217: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 140605028814848

test_cache_spans_decorator

File: tests.integrations.django.test_cache_module
Suite: py3.12-django-v6.1.1
Error: tests/integrations/django/test_cache_module.py:307: in test_cache_spans_decorator assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:307: in test_cache_spans_decorator
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

❌ Patch coverage is 75.00%. Project has 2062 uncovered lines.
❌ Project coverage is 90.18%. Comparing base (21c9144) to head (d3a6801).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/anthropic.py 75.00% ⚠️ 1 Missing and 1 partials
Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.28%    90.18%     -0.1%
==========================================
  Files          195       179       -16
  Lines        26195     21008     -5187
  Branches      9758      7524     -2234
==========================================
+ Hits         23649     18946     -4703
- Misses        2546      2062      -484
- Partials      1483      1213      -270

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review September 29, 2026 07:40
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 29, 2026 07:40

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 617b2b4. Configure here.

Comment thread sentry_sdk/integrations/anthropic.py Resolved
@alexander-alderman-webb
alexander-alderman-webb merged commit 944a204 into major/3.0 Sep 29, 2026
144 of 147 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/anthropic/drop-send-default-pii branch September 29, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants