Skip to content

Update Angular 2 docs to reflect error handler API changes - #732

Merged
benvinegar merged 2 commits into
masterfrom
update-ng2-docs
Sep 26, 2016
Merged

benvinegar merged 2 commits into
masterfrom
update-ng2-docs

Conversation

@benvinegar

@benvinegar benvinegar commented Sep 26, 2016 •

Copy link
Copy Markdown
Contributor

This was renamed to ErrorHandler: https://angular.io/docs/js/latest/api/core/index/ErrorHandler-class.html

As reported via the Sentry forum.

cc @wengole @dcramer


This change is Reviewable

@benvinegar

Copy link
Copy Markdown
Contributor Author

Needs more work. The entire bootstrap process has changed.

@benvinegar
benvinegar merged commit bbd1057 into master Sep 26, 2016
@benvinegar
benvinegar deleted the update-ng2-docs branch September 26, 2016 20:51
import Raven = require('raven-js');
import { BrowserModule } from '@angular/platform-browser';
import { AppComponent } from './app.component';
import { NgModule, ErrorHandler } from 'angular2/core';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual import is import { NgModule, ErrorHandler } from "@angular/core"

denstepa pushed a commit to denstepa/raven-js that referenced this pull request Jan 5, 2017
pull Bot pushed a commit to TheDegenerateDev5150/sentry-javascript that referenced this pull request Jun 19, 2026
…ry#732)

* feat(core): Add hook to customize source map file resolution

fixes getsentry#731

* feat(core): Address `resolveSourceMap` PR comments

1. Added better debug logging around the `resolveSourceMap` hook invocation
2. Expanded the `resolveSourceMap` doc comment to include more detail and an example use case
3. Added `resolveSourceMap` documentation to `generate-documentation-table.ts`
4. Removed the feature-specific playground test previously added

* Fix formatting

---------

Co-authored-by: Andrei Borza <andrei.borza@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants