Repository navigation
dataCallback, shouldSendCallback are passed prior callback as 2nd arg - #636
Merged
Merged
Conversation
Contributor
Yay! Much better
It would definitely cover my needs for #626 |
Contributor
|
🍪 |
Contributor
|
🍪 |
pull Bot
pushed a commit
to TheDegenerateDev5150/sentry-javascript
that referenced
this pull request
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #428 (and eventually #477)
Now you can do the following for both
setDataCallbackandsetShouldSendCallback:This way it is possible to preserve OR override the behavior of any previously set callback, without adding new API methods (e.g.
addDataCallbackandaddShouldSendCallback). It also lets subsequent callbacks mutate data before or after the prior callback is invoked, which theaddAPI is not capable of doing (execution would be serial FIFO).I'm not 100% on doing this, but I think it could be a satisfactory solution – especially since we've gone this far without it. Would love to get the community's feedback.
cc @mattrobenolt @nevir @mitsuhiko