[juriejan]

Not sure if this would be useful to anyone else, but I required the use of a callback function after determining if I'd like an error to be sent to the Sentry platform.

I've just implemented this a basic as possible, as I didn't have much time to look around and see how this project tends to implement similar patterns. So some guidance would be appreciated.

[mattrobenolt]

You need to revert that change where you re-compiled a distribution. That makes this really hard to review. See: https://raven-js.readthedocs.org/en/latest/contributing/index.html#contributing-back-code

What problem is this trying to solve that shouldSendCallback can't solve already?

[juriejan]

I've rolled back and created a single commit without compiling the distribution.

I'm currently using this in a mobile application (Cordova based) and I'd like to display a dialog to users where they can confirm that an error report should be sent. The callback allows me to respond after they have made their selection.

[mattrobenolt]

So the problem that we have with this is it breaks backwards compatibility. The API of shouldSendCallback has now changed.

I'm not opposed to this change in general, but I don't want to break existing installations.

The normal use case is what we actually document:

    shouldSendCallback: function(data) {
        // only send 10% of errors
        var sampleRate = 10;
        return (Math.random() * 100 <= sampleRate);
    }

And this change breaks that.

[benvinegar]

It's been 2 years, nobody else has advocated for this change here, and we're probably going to change the API soon anyways. Closing.