Repository navigation
feat: @sentry/vue - #2953
Merged
Merged
feat: @sentry/vue#2953
Conversation
Closed
HazAT
force-pushed
the
feat/sentry-vue
branch
from
November 5, 2020 15:02
566b863 to
b851ae7
Compare
Contributor
size-limit report
|
HazAT
marked this pull request as ready for review
November 12, 2020 14:49
HazAT
force-pushed
the
feat/sentry-vue
branch
from
November 16, 2020 07:47
476b96d to
8bce74a
Compare
HazAT
force-pushed
the
feat/sentry-vue
branch
from
November 23, 2020 09:12
6e8bd06 to
feb24d9
Compare
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
| export function init( | ||
| options: Partial<Omit<VueOptions, 'tracingOptions'> & { tracingOptions: Partial<TracingOptions> }> = {}, | ||
| ): void { | ||
| if (options.defaultIntegrations === undefined) { |
Contributor
There was a problem hiding this comment.
options.defaultIntegrations === true should also do this.
Member
Author
There was a problem hiding this comment.
It can also be an array, we have this logic everywhere so I rather not change it just here.
Contributor
There was a problem hiding this comment.
Eh, then we have a bug in 4 places :(
Sentry.init({
defaultIntegrations: true
})should work, but it won't now. Can we fix it in this PR plz?
Member
Author
There was a problem hiding this comment.
The type of the option is defined as defaultIntegrations?: false | Integration[];
So either it has to be omitted, or false or array. It can't be set to true
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
kamilogorek
reviewed
Nov 30, 2020
Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
kamilogorek
suggested changes
Dec 1, 2020
kamilogorek
self-requested a review
December 1, 2020 10:19
kamilogorek
approved these changes
Dec 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sentry/vue SDK no support for Vue3 yet.
getsentry/sentry-docs#2689