Skip to content

chore(deno): Note that OTel setup defaulting to on is unintentional - #26310

Merged
isaacs merged 1 commit into
developfrom
chore/deno-otel-default-comment
Nov 11, 2026
Merged

isaacs merged 1 commit into
developfrom
chore/deno-otel-default-comment

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Why: enableOpenTelemetrySetup defaults to true in Deno, unlike Cloudflare where it is opt-in. That default was an oversight from #17445, not a deliberate choice. Flipping it is a breaking change, so this adds a TODO(v12) comment so the current behavior doesn't look intentional to the next reader.

via Jan Peer Stöcklmair.

--

View Session [Sentry]

Co-Authored-By: Jan Peer Stöcklmair <jan.peer@sentry.io>
@JPeer264
JPeer264 marked this pull request as ready for review November 11, 2026 18:58
@JPeer264
JPeer264 requested a review from a team November 11, 2026 18:58
@JPeer264
JPeer264 requested a review from a team as a code owner November 11, 2026 18:58
@JPeer264 JPeer264 self-assigned this Nov 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Compared: db8bc4f (PR test merge using develop at c491307)

Against: c491307 (develop) · base run #65764

✅ Baseline matches: this diff contains only this PR's changes.

Path Size % Change Change
@sentry/browser 30.04 kB - -
@sentry/browser - with treeshaking flags 28.23 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 28.14 kB - -
@sentry/browser (incl. Tracing) 52.21 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 52.22 kB - -
@sentry/browser (incl. Tracing, Profiling) 55.17 kB - -
@sentry/browser (incl. Tracing, Replay) 92.75 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.5 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 97.1 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 110.52 kB - -
@sentry/browser (incl. Feedback) 47.66 kB - -
@sentry/browser (incl. sendFeedback) 30.61 kB - -
@sentry/browser (incl. FeedbackAsync) 35.63 kB - -
@sentry/browser (incl. Metrics) 31.36 kB - -
@sentry/browser (incl. Logs) 31.63 kB - -
@sentry/browser (incl. Metrics & Logs) 32.29 kB - -
@sentry/react 32.04 kB - -
@sentry/react (incl. Tracing) 54.84 kB - -
@sentry/vue 38.2 kB - -
@sentry/vue (incl. Tracing) 55.12 kB - -
@sentry/svelte 30.06 kB - -
@sentry/remix (Remix 3 client bundle) 57.93 kB - -
CDN Bundle 31.8 kB - -
CDN Bundle (incl. Tracing) 52.55 kB - -
CDN Bundle (incl. Logs, Metrics) 34.58 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 55.1 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 75.62 kB - -
CDN Bundle (incl. Tracing, Replay) 90.6 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.22 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 96.01 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 98.61 kB - -
CDN Bundle - uncompressed 92.67 kB - -
CDN Bundle (incl. Tracing) - uncompressed 155.11 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 101.01 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 162.75 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 231.09 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 275.26 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 282.89 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 287.05 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 294.68 kB - -
@sentry/nextjs (client) 58.23 kB - -
@sentry/sveltekit (client) 53.24 kB - -
@sentry/core/server 44.52 kB - -
@sentry/core/browser 13.99 kB - -
@sentry/node 149.18 kB -0.01% -4 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.16 kB - -
@sentry/node - without tracing 88.24 kB -0.01% -5 B 🔽
@sentry/node - without channel injection 138.16 kB -0.01% -5 B 🔽
@sentry/aws-serverless 97.1 kB -0.01% -4 B 🔽
@sentry/cloudflare (withSentry) - minified 204.16 kB - -
@sentry/cloudflare (withSentry) 473.86 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 229.47 kB - -

View base workflow run

@github-actions

Copy link
Copy Markdown
Contributor

Optional E2E tests

All optional checks were successful. 5 successful. See the run.

Successful checks
Check Status
✅ CI: Optional E2E Tests / E2E nextjs-16 (vinext, bun) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (vinext) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (deno) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E deno (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (cloudflare, latest) Test (optional) Successful in 2m Details

@isaacs
isaacs merged commit 480d930 into develop Nov 11, 2026
111 checks passed
@isaacs
isaacs deleted the chore/deno-otel-default-comment branch November 11, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants