Repository navigation
Conversation
Contributor
size-limit report 📦Compared: 93bc7af (PR test merge using develop at d5837c3) Against: 621a801 (develop) · base run #65856
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 10 successful. See the run.
Successful checks
|
JPeer264
marked this pull request as ready for review
November 11, 2026 14:50
JPeer264
requested review from
chargome and
isaacs
and removed request for
msonnb and
stephanie-anderson
November 11, 2026 14:50
JPeer264
force-pushed
the
jp/nextjs-bun-turbopack-worker-threads
branch
from
November 11, 2026 15:09
dead0f0 to
15c9e48
Compare
nicohrubec
approved these changes
Nov 12, 2026
| } | ||
|
|
||
| incomingUserNextConfigObject.experimental = incomingUserNextConfigObject.experimental || {}; | ||
| incomingUserNextConfigObject.experimental.turbopackPluginRuntimeStrategy ??= 'workerThreads'; |
Member
There was a problem hiding this comment.
l: if a user explicitly sets childProcesses here then this will still fail, should we add a build time warning in that case?
Member
There was a problem hiding this comment.
I guess in general we could also think about if we should add a debug log when we do the override and it succeeds
Member
Author
There was a problem hiding this comment.
Good point instinct. I added a warning in 5923c0c
isaacs
force-pushed
the
jp/nextjs-bun-turbopack-worker-threads
branch
from
November 12, 2026 10:25
15c9e48 to
5dc59ad
Compare
isaacs
force-pushed
the
jp/nextjs-bun-turbopack-worker-threads
branch
from
November 12, 2026 11:19
5dc59ad to
f049969
Compare
With the default `childProcesses` strategy, Next.js runs Turbopack loaders in `node` processes and puts `process.execArgv` into their `NODE_OPTIONS`. On Bun, `execArgv` contains `--bun`, which Node.js rejects, so `bun --bun next build` fails or hangs. `withSentryConfig` always adds loaders, so on Bun it now sets `turbopackPluginRuntimeStrategy` to `workerThreads` for Next.js 16.2 and newer, unless the user set it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/nextjs-bun-turbopack-worker-threads
branch
from
November 12, 2026 13:28
5923c0c to
297e0ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #24830
part of JS-3835
On Bun,
withSentryConfignow setsexperimental.turbopackPluginRuntimeStrategy: 'workerThreads'for Turbopack builds on Next.js 16.2 and newer, unless the user set it.Why
bun --bun next buildfails or hangs when the config has a Turbopack loader, andwithSentryConfigalways adds one. Next.js runs loaders innodeprocesses and putsprocess.execArgvinto theirNODE_OPTIONS. On Bun, that contains--bun, which Node.js rejects.Known issues
applicationKeyis set. Bun 1.4 works.