Repository navigation
test(e2e): Run nestjs-12 on Bun, Deno and Cloudflare - #26283
Merged
Merged
Conversation
sentry-junior
Bot
requested review from
a team,
JPeer264 and
stephanie-anderson
November 11, 2026 11:12
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 4 not successful, 56 successful. See the run.
Successful checks
|
Contributor
size-limit report 📦Compared: 439a5df (PR test merge using develop at edae47f) Against: edae47f (develop) · base run #65716 ✅ Baseline matches: this diff contains only this PR's changes.
|
isaacs
reviewed
Nov 11, 2026
isaacs
left a comment
isaacs
left a comment
Member
There was a problem hiding this comment.
Main concern is re the PR description.
#24844 says it is done when "every variant is green and required, or this issue records why a runtime is not supported", and "SDK defects the variants surface are fixed here, or split into their own issue". This PR adds the variants as optional, and the description lists three follow-ups as "not filed". If this merges as-is, the issue closes, and nothing tracks the follow-ups or the move to required variants.
Suggestion: change to "Refs #24844" (or "Refs"), or file the follow-ups first and link them. Then the RUNTIME branches in spans.test.ts can point at those issues, so whoever fixes them knows to remove the branches.
The follow-ups:
- Cloudflare /
Bun.serve/ Nitrohttp.serverspans useurl.scheme: 'http:'(with a colon) and stringurl.port. Node usesurl.scheme: 'http'and integerserver.port. The Cloudflare span also has nosentry.kindorhttp.response.status_text. (#26284) - The CI default Bun (1.3.14) renames classes in bundles, so we should upgrade that to 1.4 (to be filed).
JPeer264
reviewed
Nov 11, 2026
JPeer264
approved these changes
Nov 11, 2026
`nestjs-12` now runs its suite on Bun, Deno and Cloudflare (local workerd) as optional variants, next to the required Node job, following the runtime variant setup of `react-router-8-framework`. Each runtime inits its own SDK and adds `nestIntegration()` from `@sentry/nestjs`. Bun bundles the `nest build` output with `@sentry/bun/plugin`, because `bun run` gets no diagnostics channel injection. The variant pins Bun 1.4.4: Bun 1.3 renames classes in bundles (`ExampleMiddleware2`), which breaks span names taken from class names. Variants can now set `bun-version` like `deno-version`. Cloudflare bundles the same output with Vite 8 (Rollup in Vite 7 renames classes the same way) and boots Nest in the first request through `httpServerHandler`. New tests cover parameterized route names, per-request isolation, incoming trace continuation, outgoing `fetch` propagation and logs on every runtime. Expected differences branch on `RUNTIME`: the SDK name, `http.response.status_text` on Bun, the attributes of the Cloudflare `http.server` span, and the cron tests on Cloudflare, where workerd runs no timers outside a request. Refs #24844 Co-Authored-By: Isaac Schlueter <isaac.schlueter@sentry.io>
Mark the Cloudflare and Bun `RUNTIME` branches as known defects, so a later SDK fix doesn't look like a regression. Let the Workers app retry Nest's bootstrap after a failure. Compare the `sentry-trace` header as a string. Explain why each package in the Bun build stays external.
Co-Authored-By: Isaac Schlueter <isaac.schlueter@sentry.io>
isaacs
force-pushed
the
feat/nestjs-12-runtime-variants
branch
from
November 11, 2026 14:28
fa6375a to
35af7eb
Compare
isaacs
enabled stacked auto-merge (squash)
November 11, 2026 14:28
isaacs
added a commit
that referenced
this pull request
Nov 12, 2026
…26284) **Why:** `getHttpSpanDetailsFromUrlObject` copied `URL.protocol` and `URL.port` as they are, so spans got `url.scheme: 'https:'` and `url.port: '8080'` (a string). The Sentry conventions define `url.scheme` as the bare scheme (example `"https"`) and `url.port` as a number. Node `http.server` spans already send `url.scheme: 'http'` and an integer port. The helper builds the HTTP spans of Cloudflare `withSentry`, `Bun.serve`, Deno, Nitro and outgoing Node `http` requests, so their values change too: streamed `url.port` becomes `type: 'integer'`. The attribute keys stay the same, but saved queries on the old values stop matching, so the changelog gets an Important Changes entry. This is stacked on #26283 (merge that first). It also updates the `nestjs-12` Cloudflare `RUNTIME` branch from #26283: `url.scheme` is now the shared `'http'`, and `url.port` becomes `{ type: 'integer', value: 3030 }`. **How to review:** The fix is two lines in `packages/core/src/utils/url.ts`. The rest updates test expectations in core (including the outgoing `node:http` path), bun, cloudflare, `cloudflare-integration-tests`, and the `deno`, `cloudflare-mcp` and `nestjs-12` e2e apps. **Unsure about:** Key naming, not changed here: for `kind === 'server'`, the helper sets `url.port`, while Node server spans set `server.port` (OTel HTTP server spans use `server.port`). The helper already uses `server.address` for server spans, so `server.port` may be the better key there. That rename would change product-visible data, so it needs a separate decision. Refs #24844 <!-- junior-request-attribution:start --> via **Isaac Schlueter**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:agent%3A6011a8eed2b7dc364fe22ff740bf6e29 --> -- [View Session](https://junior-prod.sentry.dev/conversations/agent%3A6011a8eed2b7dc364fe22ff740bf6e29) [[Sentry]](https://sentry.sentry.io/explore/conversations/agent%3A6011a8eed2b7dc364fe22ff740bf6e29/?project=4510944073809921) <!-- junior-session-footer:end --> --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Isaac Schlueter <isaac.schlueter@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Runs the
nestjs-12suite on Bun, Deno and Cloudflare (local workerd) as optional variants next to the required Node job, with the runtime variant setup from #24598. Each runtime inits its own SDK (@sentry/bun,@sentry/denowith--preload=@sentry/deno/import,@sentry/cloudflareviainstrument.server.ts) and addsnestIntegration()from@sentry/nestjs. New tests cover parameterized route names, per-request isolation, incoming trace continuation, outgoingfetchwithsentry-trace/baggage, and logs. They pass on all four runtimes with noRUNTIMEbranches. All four variants are green locally throughpnpm run test:run nestjs-12 [--variant …].Decisions that are hard to see in the diff:
nest buildoutput with@sentry/bun/plugin(bun rungets no diagnostics channel injection, see test(bun): Run the auto-instrumentation suites with bundled scenarios #24612). The variant pins Bun 1.4.4, because Bun 1.3.14 renames classes in bundles (let X = class X {}becomesclass X2). Nest span names come from class names, so 6 span tests fail on 1.3.14 (ExampleMiddleware2,ParseIntPipe2). To allow the pin,prepare-e2e-testgets abun-versioninput that works likedeno-version.nest buildoutput (tsc emits the decorator metadata Nest DI needs) with Vite 8. Rollup in Vite 7 renames the classes the same way. Nest boots in the first request throughhttpServerHandlerfromcloudflare:node.RUNTIME, each with a comment: the SDK name; nohttp.response.status_texton Bun, because Bun'snode:httpleavesstatusMessageunset; thehttp.serverspan attributes on Cloudflare, whichwithSentrybuilds from theRequest; and the two cron tests on Cloudflare, which are skipped because workerd runs no timers outside a request, so@nestjs/schedulejobs never fire.develop, the Deno audit findings (broken route names, broken outgoing fetch) no longer happen, and Cloudflare errors arrive throughSentryGlobalFilter. The Sept 2026 audit's db-span findings don't apply here becausenestjs-12has no database.How to review: Start with
nestjs-12/package.json(variants, scripts), thenbun-build.mjs,workers/app.ts, and theRUNTIMEbranches intests/spans.test.ts.Unsure about: The variants start optional, and these SDK defects are still open, so this PR only refs #24844. The
RUNTIMEbranches intests/spans.test.tscall them out as known defects:getHttpSpanDetailsFromUrlObject(core) setsurl.schemewith a trailing colon (http:) andurl.portas a string, on Cloudflare,Bun.serveand Nitro server spans. fix(core): Seturl.schemewithout colon andurl.portas a number #26284 fixes that. The Cloudflarehttp.serverspan also has nosentry.kindorhttp.response.status_text, which nothing tracks yet.node:httpleavesres.statusMessageunset, so Bunhttp.serverspans have nohttp.response.status_text. The SDK could fall back to the standard reason phrase. Not filed yet.bun-versioninput but could change other Bun apps' results.Refs #24844
via Isaac Schlueter.
--
View Session [Sentry]