Skip to content

test: Adjust node test runner to avoid timeouts - #17663

Merged
mydea merged 1 commit into
developfrom
fn/node-runner-async
Sep 16, 2025
Merged

test: Adjust node test runner to avoid timeouts#17663
mydea merged 1 commit into
developfrom
fn/node-runner-async

Conversation

@mydea

@mydea mydea commented Sep 16, 2025

Copy link
Copy Markdown
Member

This PR hopefully helps unflake some tests, e.g. #17658, by:

  1. Using async instead of sync methods for the test runner (hopefully a bit more performant)
  2. increasing timeout for the beforeAll callback

@mydea
mydea requested review from Lms24 and andreiborza September 16, 2025 09:56
@mydea mydea self-assigned this Sep 16, 2025
@mydea mydea mentioned this pull request Sep 16, 2025
Closed
Lms24
Lms24 approved these changes Sep 16, 2025
View reviewed changes

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's give this a try!

@mydea
mydea merged commit 41cec5b into develop Sep 16, 2025
@mydea
mydea deleted the fn/node-runner-async branch September 16, 2025 11:12
@Lms24 Lms24 mentioned this pull request Sep 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes
@andreiborza andreiborza Awaiting requested review from andreiborza

Assignees

@mydea mydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea @Lms24