Skip to content

feat(opentelemetry): Export getRequestSpanData #11508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 2 commits into from
Apr 9, 2024
Merged

feat(opentelemetry): Export getRequestSpanData #11508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89259dd
feat(opentelemetry): Export `getRequestSpanData`
mydea Apr 9, 2024
abf3558
fix export...
mydea Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/node/src/integrations/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
setCapturedScopesOnSpan,
spanToJSON,
} from '@sentry/core';
import { _INTERNAL, getClient, getSpanKind } from '@sentry/opentelemetry';
import { getClient, getRequestSpanData, getSpanKind } from '@sentry/opentelemetry';
import type { IntegrationFn } from '@sentry/types';

import { stripUrlQueryAndFragment } from '@sentry/utils';
Expand Down Expand Up @@ -160,7 +160,7 @@ function _addRequestBreadcrumb(span: Span, response: HTTPModuleRequestIncomingMe
return;
}

const data = _INTERNAL.getRequestSpanData(span);
const data = getRequestSpanData(span);
addBreadcrumb(
{
category: 'http',
Expand Down
4 changes: 2 additions & 2 deletions packages/node/src/integrations/node-fetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { SpanKind } from '@opentelemetry/api';
import type { Instrumentation } from '@opentelemetry/instrumentation';
import { registerInstrumentations } from '@opentelemetry/instrumentation';
import { addBreadcrumb, defineIntegration } from '@sentry/core';
import { _INTERNAL, getSpanKind } from '@sentry/opentelemetry';
import { getRequestSpanData, getSpanKind } from '@sentry/opentelemetry';
import type { IntegrationFn } from '@sentry/types';
import { logger } from '@sentry/utils';
import { DEBUG_BUILD } from '../debug-build';
Expand Down Expand Up @@ -88,7 +88,7 @@ function _addRequestBreadcrumb(span: Span): void {
return;
}

const data = _INTERNAL.getRequestSpanData(span);
const data = getRequestSpanData(span);
addBreadcrumb({
category: 'http',
data: {
Expand Down
12 changes: 1 addition & 11 deletions packages/opentelemetry/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { getRequestSpanData } from './utils/getRequestSpanData';
export { getRequestSpanData } from './utils/getRequestSpanData';

export type { OpenTelemetryClient } from './types';
export { wrapClientClass } from './custom/client';
Expand Down Expand Up @@ -39,13 +39,3 @@ export { openTelemetrySetupCheck } from './utils/setupCheck';

// Legacy
export { getClient } from '@sentry/core';

/**
* The following internal utils are not considered public API and are subject to change.
* @hidden
*/
const _INTERNAL = {
getRequestSpanData,
} as const;

export { _INTERNAL };