Skip to content

ref: Remove user segment #10575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lforst merged 2 commits into from
Feb 9, 2024
Merged

ref: Remove user segment #10575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b8c5b4
ref: Remove user segment
Feb 8, 2024
dd2ffab
fixfixfix
Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions dev-packages/browser-integration-tests/suites/replay/dsc/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ sentryTest(

await page.evaluate(() => {
const scope = (window as unknown as TestWindow).Sentry.getCurrentScope();
scope.setUser({ id: 'user123', segment: 'segmentB' });
scope.setUser({ id: 'user123' });
scope.addEventProcessor(event => {
event.transaction = 'testTransactionDSC';
return event;
Expand All @@ -53,7 +53,6 @@ sentryTest(
expect(envHeader.trace).toBeDefined();
expect(envHeader.trace).toEqual({
environment: 'production',
user_segment: 'segmentB',
sample_rate: '1',
trace_id: expect.any(String),
public_key: 'public',
Expand Down Expand Up @@ -84,7 +83,7 @@ sentryTest(

await page.evaluate(() => {
const scope = (window as unknown as TestWindow).Sentry.getCurrentScope();
scope.setUser({ id: 'user123', segment: 'segmentB' });
scope.setUser({ id: 'user123' });
scope.addEventProcessor(event => {
event.transaction = 'testTransactionDSC';
return event;
Expand All @@ -101,7 +100,6 @@ sentryTest(
expect(envHeader.trace).toBeDefined();
expect(envHeader.trace).toEqual({
environment: 'production',
user_segment: 'segmentB',
sample_rate: '1',
trace_id: expect.any(String),
public_key: 'public',
Expand Down Expand Up @@ -144,7 +142,7 @@ sentryTest(

await page.evaluate(() => {
const scope = (window as unknown as TestWindow).Sentry.getCurrentScope();
scope.setUser({ id: 'user123', segment: 'segmentB' });
scope.setUser({ id: 'user123' });
scope.addEventProcessor(event => {
event.transaction = 'testTransactionDSC';
return event;
Expand All @@ -162,7 +160,6 @@ sentryTest(
expect(envHeader.trace).toBeDefined();
expect(envHeader.trace).toEqual({
environment: 'production',
user_segment: 'segmentB',
sample_rate: '1',
trace_id: expect.any(String),
public_key: 'public',
Expand Down Expand Up @@ -195,7 +192,7 @@ sentryTest(

await page.evaluate(async () => {
const scope = (window as unknown as TestWindow).Sentry.getCurrentScope();
scope.setUser({ id: 'user123', segment: 'segmentB' });
scope.setUser({ id: 'user123' });
scope.addEventProcessor(event => {
event.transaction = 'testTransactionDSC';
return event;
Expand All @@ -213,7 +210,6 @@ sentryTest(
expect(envHeader.trace).toBeDefined();
expect(envHeader.trace).toEqual({
environment: 'production',
user_segment: 'segmentB',
sample_rate: '1',
trace_id: expect.any(String),
public_key: 'public',
Expand Down
2 changes: 1 addition & 1 deletion ...ackages/browser-integration-tests/suites/tracing/envelope-header-transaction-name/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Sentry.init({
});

const scope = Sentry.getCurrentScope();
scope.setUser({ id: 'user123', segment: 'segmentB' });
scope.setUser({ id: 'user123' });
scope.addEventProcessor(event => {
event.transaction = 'testTransactionDSC';
return event;
Expand Down
1 change: 0 additions & 1 deletion ...ackages/browser-integration-tests/suites/tracing/envelope-header-transaction-name/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ sentryTest(
expect(envHeader.trace).toBeDefined();
expect(envHeader.trace).toEqual({
environment: 'production',
user_segment: 'segmentB',
sample_rate: '1',
transaction: expect.stringContaining('/index.html'),
trace_id: expect.any(String),
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/browser-integration-tests/suites/tracing/envelope-header/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Sentry.init({
});

const scope = Sentry.getCurrentScope();
scope.setUser({ id: 'user123', segment: 'segmentB' });
scope.setUser({ id: 'user123' });
scope.addEventProcessor(event => {
event.transaction = 'testTransactionDSC';
return event;
Expand Down
1 change: 0 additions & 1 deletion dev-packages/browser-integration-tests/suites/tracing/envelope-header/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ sentryTest(
expect(envHeader.trace).toBeDefined();
expect(envHeader.trace).toEqual({
environment: 'production',
user_segment: 'segmentB',
sample_rate: '1',
trace_id: expect.any(String),
public_key: 'public',
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/node-integration-tests/suites/express/sentry-trace/baggage-header-out/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Sentry.init({
transport: loggingTransport,
});

Sentry.setUser({ id: 'user123', segment: 'SegmentA' });
Sentry.setUser({ id: 'user123' });

app.use(Sentry.Handlers.requestHandler());
app.use(Sentry.Handlers.tracingHandler());
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/node-integration-tests/suites/express/sentry-trace/baggage-header-out/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ test('should attach a baggage header to an outgoing request.', async () => {
test_data: {
host: 'somewhere.not.sentry',
baggage:
'sentry-environment=prod,sentry-release=1.0,sentry-user_segment=SegmentA,sentry-public_key=public' +
'sentry-environment=prod,sentry-release=1.0,sentry-public_key=public' +
',sentry-trace_id=86f39e84263a4de99c326acab3bfe3bd,sentry-sample_rate=1,sentry-transaction=GET%20%2Ftest%2Fexpress' +
',sentry-sampled=true',
},
Expand Down
Loading