Skip to content

build(ci): Properly skip node CI steps when not changed - #10487

Merged
mydea merged 1 commit into
developfrom
fn/avoid-node-bindings
Feb 5, 2024
Merged

mydea merged 1 commit into
developfrom
fn/avoid-node-bindings

Conversation

@mydea

@mydea mydea commented Feb 5, 2024

Copy link
Copy Markdown
Member

One part of #10486, actually our checks for this were not correct 😅

This is still only a partial fix as if we change anything in core etc. we'll still have the build overhead every time, but it's something!

@mydea
mydea requested review from JonasBa and lforst February 5, 2024 08:41
@mydea mydea self-assigned this Feb 5, 2024
@github-actions

github-actions Bot commented Feb 5, 2024

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.2 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.43 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.36 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 63.04 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.38 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.25 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.33 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.34 KB (0%)
@sentry/browser - Webpack (gzipped) 22.6 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.17 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.72 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.5 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.66 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 213.68 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.49 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74.01 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.63 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.8 KB (0%)
@sentry/react - Webpack (gzipped) 22.63 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.42 KB (+1% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 51.57 KB (+1.52% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)

@mydea
mydea merged commit 004efa6 into develop Feb 5, 2024
@mydea
mydea deleted the fn/avoid-node-bindings branch February 5, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants