Repository navigation
Error's cause not respected (for non-Error causes) #9913
Description
Is there an existing issue for this?
- I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
- I have reviewed the documentation https://docs.sentry.io/
- I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/browser
SDK Version
7.88.0
Framework Version
n/a
Link to Sentry event
https://prisjakt-ab.sentry.io/issues/4738454694/events/latest/?project=4506415694348288
SDK Setup
Sentry.init({
// ...
integrations: [
new Sentry.Integrations.Http(),
new Sentry.Integrations.FunctionToString(),
new Sentry.Integrations.ContextLines(),
new Sentry.Integrations.LocalVariables(),
new Sentry.Integrations.LinkedErrors(),
new Sentry.Integrations.RequestData({
include: {
user: false,
ip: true,
cookies: false,
data: false,
headers: false,
query_string: false,
url: false,
},
}),
],
// ...
});Sentry.withScope((scope) => {
scope.setSDKProcessingMetadata({ request: ctx.request });
Sentry.captureException(error);
});Steps to Reproduce
- Do API request:
try {
const res = await doFetch();
if (res.error) {
throw new Error("Request failed", {
cause: res
});
}- Catch error and log it
} catch (err) {
Sentry.withScope((scope) => {
scope.setSDKProcessingMetadata({ request: ctx.request });
Sentry.captureException(err);
});
}This adds the failed API response as cause on the error object. Yet on the linked issue in Sentry, there is no reference to that error cause.
Expected Result
The cause should somehow show in Sentry. I saw it do that for Error-causes. I saw some other GH issue thread that had something to do with a React boundary, but that was fixed and closed, so likely not applicable (also I can't find the link any more)
Actual Result
The cause doesn't show on the Sentry issue.
Activity
[-]Error `cause` not respected (for non-Error casuses)[/-][+]Error `cause` not respected (for non-Error causes)[/+][-]Error `cause` not respected (for non-Error causes)[/-][+]Error's `cause` not respected (for non-Error causes)[/+]lforst commentedon Dec 19, 2023
Hi, linking errors based on the
causeproperty with theLinkedErrorsintegration is only supported if the value behindcauseis anError. What you likely need and want is theExtraErrorDataintegration. Let me know if this helps!jeengbe commentedon Dec 19, 2023
Ah so when I see an issue in Sentry with another linked issue, that's a linked Sentry issue that's linked from the
cause?lforst commentedon Dec 19, 2023
I don't think it's an "issue" but definitely another error object on the
causeproperty of the captured error.jeengbe commentedon Dec 19, 2023
Is that something you would consider supporting? Structured non-
Errordata is explicitly allowed according to MDN https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause#providing_structured_data_as_the_error_causelforst commentedon Dec 19, 2023
We definitely could! Putting on backlog.
lforst commentedon Dec 19, 2023
Figured this is so easy to do I'll just open a PR