Instrumentation for node-cron library #9892

Activity

1. AbhiPrasad

   added

   Type: Improvement

   Package: Node

   Feature: Crons

   on Dec 18, 2023
2. AbhiPrasad

   changed the title [-]Instrumentation for Node cron library[/-] [+]Instrumentation for node-cron library[/+] on Dec 18, 2023
3. AbhiPrasad

   assigned

   timfish

   on Dec 18, 2023
4. timfish commented on Dec 18, 2023

   

   timfish

   on Dec 18, 2023

   Collaborator

   More actions

   I guess Sentry does not support month/day names like node-cron does?

   For month and week day you also may use names or short names. e.g:

   var cron = require('node-cron');
   
   cron.schedule('* * * January,September Sunday', () => {
     console.log('running on Sundays of January and September');
   });

   Or with short names:

   var cron = require('node-cron');
   
   cron.schedule('* * * Jan,Sep Sun', () => {
     console.log('running on Sundays of January and September');
   });
5. gaprl commented on Dec 18, 2023

   

   gaprl

   on Dec 18, 2023

   More actions

   I guess Sentry does not support month/day names like node-cron does?

   Hey @timfishk, correct, Crons only supports the crontab syntax. However, we could parse it in the front-end and send it like this to Sentry: * * * January,September Sunday becomes * * * 1,7 0 which would represent the same thing.

   Seems like they are already doing something similar here: src/convert-expression/index.js#L51-L62

   👍React with 👍1Reacted by Tim Fish
6. gaprl commented on Dec 18, 2023

   

   gaprl

   on Dec 18, 2023

   More actions

   Ideally we could automatically instrument all monitors by doing something like:

   import cron from 'node-cron';
   
   Sentry.withMonitorIntegration(cron);
   
   cron.schedule('* * * * *', () => {
     console.log('running a task every minute');
   });
7. AbhiPrasad

   closed this as completedin #9904on Jan 3, 2024