Skip to content

Untrue comment in source code for HTTP integrations #9211

Closed

Description

@rudolfbyker

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/node

SDK Version

7.73

Framework Version

No response

Link to Sentry event

No response

SDK Setup

No response

Steps to Reproduce

  1. Read the docs: It says that the HTTP integration creates spans for outgoing HTTP requests, but it does not create a transaction. You need to create the transaction manually, or use something like express middleware, which creates a transaction for each incoming HTTP request, to which the spans of outgoing HTTP requests are added (true).
  2. Read the comment at
    * The http module integration instruments Node's internal http module. It creates breadcrumbs, transactions for outgoing
    which says that the HTTP integration creates transactions (untrue).
  3. Be confused, because the docs and source code comments contradict.

Expected Result

Docs and source code comments do not contradict.

Actual Result

Docs and source code comments contradict.

Activity

  1. moved this to Waiting for: Product Owner in GitHub Issues with 👀on Oct 10, 2023
  2. AbhiPrasad commented on Oct 11, 2023

    @AbhiPrasad
    Contributor

    Hey, you're right that we need to clean up that inconsistency. PRs are welcome!

  3. moved this from Waiting for: Product Owner to No status in GitHub Issues with 👀on Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions