You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
if (isString(pattern)) {
return requireExactStringMatch ? value === pattern : value.includes(pattern);
}
value is defined to be a String.
String.includes is only defined in ES6, and will fail with ES5 only browsers (including IE 11). IE 11 and other ES5 browsers are listed as supported (as long as you are using the ES5 bundle) without polyfills (post Sentry version 5.7.0) in the matrix at https://docs.sentry.io/platforms/javascript/troubleshooting/supported-browsers/
Expected Result
Sentry to work in ES5 browsers without the need for polyfills, or documentation to be updated to state which polyfills are needed for the ES5 bundle to correctly work.
Actual Result
IE11 and other ES5 browsers throw exceptions when this code is invoked.
we have just released 7.45.0, which includes polyfills for unsupported ES6 functions, so should fully work on ES5 with no issues!
If something is still not working for you on ES5, please feel free to reopen. We added a bunch of safeguards to ensure this remains ES5 compatible in the future and no unsupported stuff sneaks in again. Sorry about the inconvenience!
Activity
mydea commentedon Mar 23, 2023
Hi,
thanks for writing in! We actually also noticed this recently and have already merged a PR to fix this by including a minimal polyfill: #7550
this will be included in the next release!
mydea commentedon Mar 24, 2023
Hello,
we have just released 7.45.0, which includes polyfills for unsupported ES6 functions, so should fully work on ES5 with no issues!
If something is still not working for you on ES5, please feel free to reopen. We added a bunch of safeguards to ensure this remains ES5 compatible in the future and no unsupported stuff sneaks in again. Sorry about the inconvenience!