Sentry CDN ES 5 bundle is not ES 5 (includes class keyword) #7541

Activity

1. erikt9

   added

   Type: Bug

   on Mar 21, 2023
2. getsantry

   added

   Status: Untriaged

   on Mar 21, 2023
3. mydea commented on Mar 21, 2023

   

   mydea

   on Mar 21, 2023

   Member

   More actions

   Hey @erikt9 ,

   thanks for reporting. Not quite sure what is going on there, we'll investigate and ship a fix for this asap!
4. AbhiPrasad

   added

   Status: Confirmed

   on Mar 21, 2023
5. getsantry

   removed

   Status: Untriaged

   on Mar 21, 2023
6. AbhiPrasad

   assigned

   mydea

   on Mar 21, 2023
7. mydea commented on Mar 21, 2023

   

   mydea

   on Mar 21, 2023

   Member

   More actions

   Hello,

   this is resolved in 7.44.2! Sorry about the inconvenience. We'll add guards to make sure this doesn't happen anymore.
8. mydea

   closed this as completedon Mar 21, 2023
9. kevireilly commented on Mar 27, 2023

   

   kevireilly

   on Mar 27, 2023

   More actions

   7.44.2 and 7.45.0 may still have an ES5 issue, though it may not be the exact same as reported here. We found that @sentry-internal/tracing needed to be explicitly transpiled.

   Minified error

   SyntaxError: Unexpected token '>'
   

   Unminified error

   SyntaxError: Unexpected token '('
   

   Unminified source

   function _autoloadDatabaseIntegrations() {
     const carrier = getMainCarrier();
     if (!carrier.__SENTRY__) {
       return;
     }
     const packageToIntegrationMapping = {
       mongodb() { // <<<<<<------ syntax error here
         const integration = dynamicRequire(module, './node/integrations/mongo');
         return new integration.Mongo();
       },
       mongoose() {
         const integration = dynamicRequire(module, './node/integrations/mongo');
         return new integration.Mongo({ mongoose: true });
       },
       mysql() {
         const integration = dynamicRequire(module, './node/integrations/mysql');
         return new integration.Mysql();
       },
       pg() {
         const integration = dynamicRequire(module, './node/integrations/postgres');
         return new integration.Postgres();
       },
     };
     const mappedPackages = Object.keys(packageToIntegrationMapping)
       .filter(moduleName => !!loadModule(moduleName))
       .map(pkg => {
         try {
           return packageToIntegrationMapping[pkg]();
         } catch (e) {
           return undefined;
         }
       })
       .filter(p => p) ;
     if (mappedPackages.length > 0) {
       carrier.__SENTRY__.integrations = [...(carrier.__SENTRY__.integrations || []), ...mappedPackages];
     }
   }
   
10. erikt9 commented on Mar 29, 2023

    

    erikt9

    on Mar 29, 2023

    Author

    More actions

    @kevireilly You'll probably want to make a new issue if you want the sentry team to look at it.
11. mydea commented on Mar 29, 2023

    

    mydea

    on Mar 29, 2023

    Member

    More actions

    Yes, please create a new issue for this - esp. including: Are you talking about the ES5 CDN bundle? This is the only thing that we currently transpile. If you use the npm package, you have to take care of transpilation (and including polyfills) yourself, if you want to support ES5!