Repository navigation
React Native: TypeError: undefined is not an object (evaluating 'originalCallback.call') #692
Description
Getting an exception here: https://github.com/getsentry/raven-js/blob/master/plugins/react-native.js#L89
TypeError: undefined is not an object (evaluating 'originalCallback.call')
Adding a guard seems to resolve the problem, though I don't understand the source enough to know if that's the right solution:
Raven.setShouldSendCallback(function(data, originalCallback) {
if (originalCallback && !(FATAL_ERROR_KEY in data)) {
return originalCallback.call(this, data);
}
Activity
benvinegar commentedon Aug 18, 2016
This code should definitely guard against
originalCallbacknot being defined. Feeling bad I didn't notice this during review.Thanks for reporting, we'll have a patch soon.
cc @nevir
Don't assume previous shouldSendCallback exists in RN plugin (fixes #692
nevir commentedon Aug 18, 2016
Doh! Sorry about that :(
Don't assume previous shouldSendCallback exists in RN plugin (fixes g…
feat: Default to automatically setting commits on release (getsentry#692