[Replay] Keyboard input should count as user-activity and extend the life of a session #6532

Activity

1. mydea

   transferred this issue fromgetsentry/sentry-replayon Dec 14, 2022
2. mydea

   added

   Package: replay

   on Dec 14, 2022
3. mydea

   changed the title [-]Keyboard input should count as user-activity and extend the life of a session[/-] [+][Replay] Keyboard input should count as user-activity and extend the life of a session[/+] on Dec 14, 2022
4. github-actions commented on Jan 5, 2023

   

   github-actionsBot

   on Jan 5, 2023

   Contributor

   More actions

   This issue has gone three weeks without activity. In another week, I will close it.

   But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

   ---

   "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀
5. github-actions

   added

   Status: Stale

   on Jan 5, 2023
6. github-actions

   closed this as not plannedon Jan 12, 2023
7. p-himik commented on May 3, 2023

   

   p-himik

   on May 3, 2023

   More actions

   Just noticed this as well - saw some really strange behavior on a replay and couldn't grasp what was going on initially. Turned out, a user was hitting a key combination that the app handles but Sentry wasn't showing that.
8. mydea

   reopened this on May 4, 2023
9. mydea commented on May 4, 2023

   

   mydea

   on May 4, 2023

   Member

   More actions

   Hi @p-himik ,

   thanks for writing in.
   I fear collecting which keys are pressed is not really feasible, from a PII perspective - we can't easily determine why a key is pressed, and we would def. not want to capture e.g. what a user types into a field (imagine us capturing a breadcrumb for each key pressed while a user types into a password field... 😓 ). I think the use case of capturing keyboard shortcuts is valid, though. I wonder how we could identify this... maybe only capture the keys pressed when no input is focused? I guess this may be safe to do... WDYT @ryan953 / @billyvg / @bruno-garcia
10. p-himik commented on May 4, 2023

    

    p-himik

    on May 4, 2023

    Last edited by p-himik

    More actions

    Things that are useful in my own projects:

    • Capturing some particular or all keys when no input is focused (still problematic because a user might start typing some PII while thinking that the right input is focused, without looking at the screen)
    • Capturing key combinations with modifiers regardless of what is focused (Ctrl+z being the most salient one, probably)
    • Knowing that a regular character key has been entered into an input field (this is probably already handled, don't recall)

    Personally, I would be quite happy if there were these things implemented:

    • If a key is pressed with Ctrl/Alt/Command/Option, log it
    • If a key is not a character, log it (Home, End, arrow keys, etc.)
    • If a key is pressed without a modifier or with Shift, log only the fact that something has been pressed, without writing the key itself
    • Have an ability to override the above for particular keys, maybe in particular contexts (e.g. suppose I'm emulating Vim on my page - I would like to log all navigation but avoid logging in the Insert mode)

    👍React with 👍3Reacted by Francesco Gringl-Novy, Bruno Garcia and Billy Vong
11. github-actions

    added

    Waiting for: Team

    and removed

    Status: Stale

    on May 4, 2023
12. mydea

    closed this as completedin #8051on May 10, 2023