Repository navigation
Support createHashRouter from React Router 6.4 #6251
Description
Problem Statement
React Router 6.4 introduced Data API, with 3 new ways to initialize a router:
createBrowserRouter: feat(react): Add tracing support for React Router 6.4createBrowserRouter. #6172createMemoryRouteralso covered by feat(react): Add tracing support for React Router 6.4createBrowserRouter. #6172- and
createHashRouter
We should support usage of createHashRouter for users that prefer it over createBrowserRouter.
Solution Brainstorm
Implementation should be fairly similar to createBrowserRouter, we should still be able to subscribe routing events.
Also need to check:
- How would route parameterization work with hash urls?
- Do we need a URL parser, or can we get declarative route info from subscription?
Alternatively we can also consider writing a wrapper for <RouterProvider>, which all three types of routers are rendered in.
Reacted by Arvid Nikka
Reacted by Pietro Paolo Vismara and A. Schueler
Activity
github-actions commentedon Dec 13, 2022
This issue has gone three weeks without activity. In another week, I will close it.
But! If you comment or otherwise update it, I will reset the clock, and if you label it
Status: BacklogorStatus: In Progress, I will leave it alone ... forever!"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀
pietrovismara commentedon Mar 4, 2023
We are stuck on this as we have to use the hash router.
Anyone could point me in the right direction to make sentry work with
react-router@6.4+createHashRouter?I checked the PR to integrate
createBrowserRouterand it doesn't look so complicated so I'm wondering if there is some fundamental difference in the way browser and hash routers should be handled by sentry.