You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
express process termination with async exceptions #5931
Hey, thanks for writing in! We made the change in #5627 because routing the error to next is incorrect behaviour as per #1922 (comment) - Sentry should not be doing this.
Does the behaviour you want occur when you remove the Sentry library?
@AbhiPrasad Hi yep looks like we were wrong in our implementation and it only worked as sentry was listening to the event.
We should have been catching the exception on the promise and calling next ourselves.
Activity
AbhiPrasad commentedon Oct 12, 2022
Hey, thanks for writing in! We made the change in #5627 because routing the error to
nextis incorrect behaviour as per #1922 (comment) - Sentry should not be doing this.Does the behaviour you want occur when you remove the Sentry library?
ljearyscg commentedon Oct 12, 2022
@AbhiPrasad Hi yep looks like we were wrong in our implementation and it only worked as sentry was listening to the event.
We should have been catching the exception on the promise and calling next ourselves.
as per here https://reflectoring.io/express-error-handling/
thanks for replying.
build(deps-dev): bump axios from 1.1.2 to 1.6.0 in /packages/e2e-test…
build(deps-dev): bump axios from 1.1.2 to 1.6.0 in /packages/e2e-test…
build(deps-dev): bump axios from 1.1.2 to 1.6.0 in /packages/e2e-test…
build(deps-dev): bump axios from 1.1.2 to 1.6.0 in /packages/e2e-test…
build(deps): bump axios from 1.3.4 to 1.6.0 in /packages/browser-inte…