Repository navigation
Sentry for Remix overwrites root loader data #5553
Description
Is there an existing issue for this?
- I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
- I have reviewed the documentation https://docs.sentry.io/
- I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases
How do you use Sentry?
Sentry Saas (sentry.io)
Which package are you using?
@sentry/remix
SDK Version
7.9.0
Framework Version
18.2.0
Link to Sentry event
No response
Steps to Reproduce
Since Sentry 7.9.0, any data returned by the root loader is overwritten with an object with only sentryTrace and sentryBaggage attributes. Looking at this PR, appears these attributes were meant to be merged alongside the original loader response.
Expected Result
The root loader should return an object with the user's returned attributes, merged with Sentry wrapped attributes.
Actual Result
Returned data:
useLoaderData() response:
Activity
shirshendubhowmick commentedon Aug 9, 2022
Exact same issue
Fenntasy commentedon Aug 10, 2022
I have the same bug and the issue here is the use of the
jsonfunction.in your example, replacing it with:
Should make it work but that's not the way of fixing it. However, I see it has been fixed in the code already, just not published so I hope it should be good quickly.
EDIT: It's been fixed 14h ago 9d38065
onurtemizkan commentedon Aug 10, 2022
Thanks for reporting this folks! Fix is merged (#5548) and will be published soon!
Duplicate: #5539 and #5549
mattrigg9 commentedon Aug 10, 2022
Awesome, thanks for the quick response and patch!