ReferenceError: name is not defined

Is there an existing issue for this?

I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
I have reviewed the documentation https://docs.sentry.io/
I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which package are you using?

@sentry/remix

SDK Version

7.6.0

Framework Version

7.6.0

Link to Sentry event

https://sentry.io/organizations/syncwith/issues/3415220654/?project=5880203&query=is%3Aunresolved

Steps to Reproduce

I am trying out sentry-remix for the first time, and now when my app encounters a 404 it seems like our 404 page doesn't get used, and I get an unexpected exception tracked to sentry

The error seems to be in:

https://github.com/getsentry/sentry-javascript/blob/master/packages/remix/src/utils/instrumentServer.ts

My app in root looks like:

function App() {
  const data = useLoaderData<RootLoaderData>();
  return (
    <Document data={data}>
      <Outlet />
      <footer></footer>
    </Document>
  );
}

export default withSentry(App);

Expected Result

I expected our normal 404 page to show, I think through the CatchBoundary

Actual Result

Error: name is not defined
File "/Users/alex/dev/micro/webapp/node_modules/@sentry/remix/cjs/utils/instrumentServer.js", line 65, col 40, in
captureRemixServerException(err, name);
File "/Users/alex/dev/micro/webapp/node_modules/@remix-run/server-runtime/server.js", line 393, col 18, in handleDocumentRequest
return await handleDocumentRequest(request.clone(), responseStatusCode, responseHeaders, entryContext);
File "/Users/alex/dev/micro/webapp/node_modules/@remix-run/server-runtime/server.js", line 49, col 18, in requestHandler
response = await handleDocumentRequest({
File "/Users/alex/dev/micro/webapp/node_modules/@sentry/remix/cjs/utils/instrumentServer.js", line 134, col 16, in
var res = (await origRequestHandler.call(this, request, loadContext)) ;
File "/Users/alex/dev/micro/webapp/node_modules/@remix-run/express/server.js", line 41, col 22, in
let response = await handleRequest(request, loadContext);

I might be misunderstanding, but I don't see what name refers to here, it seems like this would fail to compile... wouldn't it?

https://github.com/getsentry/sentry-javascript/blob/master/packages/remix/src/utils/instrumentServer.ts#L123

function makeWrappedDocumentRequestFunction(
  origDocumentRequestFunction: HandleDocumentRequestFunction,
): HandleDocumentRequestFunction {
  return async function (
    this: unknown,
    request: Request,
    responseStatusCode: number,
    responseHeaders: Headers,
    context: Record<symbol, unknown>,
  ): Promise<Response> {
    let res: Response;

    const activeTransaction = getActiveTransaction();
    const currentScope = getCurrentHub().getScope();

    if (!activeTransaction || !currentScope) {
      return origDocumentRequestFunction.call(this, request, responseStatusCode, responseHeaders, context);
    }

    try {
      const span = activeTransaction.startChild({
        op: 'remix.server.documentRequest',
        description: activeTransaction.name,
        tags: {
          method: request.method,
          url: request.url,
        },
      });

      res = await origDocumentRequestFunction.call(this, request, responseStatusCode, responseHeaders, context);

      span.finish();
    } catch (err) {
      captureRemixServerException(err, name);
      throw err;
    }

    return res;
  };
}

@alexblack

Thanks for reporting this @alexblack, will look into why TS allowed that.

Great!

Do you know if/when a new release will be made with this fix? Thanks!!

@alexblack

@alexblack We have a couple more remix fixes to make, and then we'll make another release! End of week by latest.

@AbhiPrasad

@AbhiPrasad ok thanks, I reverted to 7.5.1 to avoid this issue of sentry throwing errors on 404 pages

@alexblack

We've just released the fixes in 7.7.0! Thank you for your patience @alexblack!

Great to hear, thanks for letting me know

Navigation Menu

Repository navigation

ReferenceError: name is not defined #5401

Is there an existing issue for this?

How do you use Sentry?

Which package are you using?

SDK Version

Framework Version

Link to Sentry event

Steps to Reproduce

Expected Result

Actual Result

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

ReferenceError: name is not defined #5401

Description

Is there an existing issue for this?

How do you use Sentry?

Which package are you using?

SDK Version

Framework Version

Link to Sentry event

Steps to Reproduce

Expected Result

Actual Result

Activity

alexblack commented on Jul 10, 2022

onurtemizkan commented on Jul 11, 2022

alexblack commented on Jul 11, 2022

alexblack commented on Jul 11, 2022

AbhiPrasad commented on Jul 11, 2022

alexblack commented on Jul 14, 2022

AbhiPrasad commented on Jul 15, 2022

alexblack commented on Jul 15, 2022

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions