Repository navigation
Provide a new hook for harvesting "extra" data from an Error object #483
Description
It's semi-common practice to tack on additional properties onto an Error object.
Something like:
var err = new Error('lol');
err.thing = 'something awesome happened';
throw err;And these additional properties are useful in lots of cases.
We need a hook to provide a way to collect this information and transform it into extra data that gets passed along.
We have 3 options here:
- Collect all properties automatically and hope we don't blow up our data limits.
- Provide a new hook to preprocess the
Errorwhere these can be extracted - Augment
dataCallbackto provide theErrorso they can inspect and modify the data packet themselves.
Reacted by Yannick Croissant, robertsami and Keith Halterman
Activity
pkaminski commentedon Feb 3, 2016
+1 on any/all of these options. Option 1 would match the Node library's behavior (I believe), but having a hook that gets access to the original error would also be useful in other cases.
benvinegar commentedon Nov 23, 2016
My only concern here is that we blow up memory usage by automatically collecting extra attributes, since raven-js can't gzip like raven-node does.
The callback approach seems easiest, but we'd need
dataCallbackto accept a 2nd argument (the original error), but we've already started using that argument to pass an "original" callback if one existed previously. I'm not fond of adataCallbacksignature that looks likefunction (data, originalCallback, originalError).Sigh.
joshma commentedon Nov 23, 2016
It wouldn't match the node library, which may be enough reason to rule it out, but IMO just reading the
error.extrafield could be a 4th option. It's easy to use and avoids accidentally collecting too much data.robertsami commentedon Nov 23, 2016
Agreed with 4th option, but also putting in a vote for the second option listed by @mattrobenolt "Provide a new hook to preprocess the
Errorwhere these can be extracted". Avoids memory issues, preserves flexibility, and does not lead to adataCallbacksignature you're not fond of :)Add an errorCallback for adding data details from the raw error object
Add an errorCallback for adding data details from the raw error object
blittle commentedon Dec 15, 2016
I just added a PR for the second option. Would love feedback!