Repository navigation
Raven throws "module is not defined" #287
Description
Occurs in master branch, 5390681 due to the code from PR #261:
} else if (isObject(module)) {
// browserify
module.exports = Raven;
} else if (isObject(exports)) {
// CommonJS
exports = Raven;
}
To fix, it should be replaced with:
} else if (isObject(window.module)) {
// browserify
module.exports = Raven;
} else if (isObject(window.exports)) {
// CommonJS
exports = Raven;
}
Activity
mattrobenolt commentedon Nov 9, 2014
So... I don't know everything here, but I'm pretty sure this will break browserify.
In what context did this break for you? Browserify does not let you use
window.@clayzermk1?
mattrobenolt commentedon Nov 9, 2014
Wait, yeah, this 100% won't work. wtf
mattrobenolt commentedon Nov 9, 2014
We have to replace these with explicit
typeofchecks instead of usingisObject.mattrobenolt commentedon Nov 9, 2014
To avoid the
ReferenceError. Ugh.mattrobenolt commentedon Nov 9, 2014
@vitalybe How's f6e8cbe look?
clayzermk1 commentedon Nov 9, 2014
Just for reference, I had no trouble with a build of master that used the isObject calls using browserify.
Just for a sanity check, I'll build f6e8cbe tomorrow and check it out on browserify - I don't anticipate any issues.
mattrobenolt commentedon Nov 10, 2014
If
moduleexisted, it wouldn't fail. This will 100% fail with aReferenceErrorif it was left undefined. Which is why I needed to replace it with explicittypeofchecks and can't useisObject.Did I mention that I hate JavaScript before? 👍
clayzermk1 commentedon Nov 10, 2014
f6e8cbe looks to be working fine here.
vitalybe commentedon Nov 11, 2014
Looks good :)
Fix ReferenceErrors since we can't qualify with `window`
ref: Improve log message when sourcemap cannot be found (getsentry#287)