console.assert adds a breadcrumb even when assertion doesn't fail

Review the documentation: https://docs.sentry.io/
Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
Use the latest release: https://github.com/getsentry/sentry-javascript/releases
Provide a link to the affected event from your Sentry account

Package + Version

Version:

5.6.2

Description

With Sentry enabled, trigger console.assert(true, 'this never fails') and then capture exception. You'll see breadcrumb for non-failing assert added in the event. It's confusing and wrong to have breadcrumb added if assertion didn't fail. Browser doesn't print anything for non-failing assertion.

Relevant code:

sentry-javascript/packages/browser/src/integrations/breadcrumbs.ts

Lines 97 to 107 in 4cee445

    
           if (level === 'assert') { 
        
             if (args[0] === false) { 
        
               breadcrumbData.message = `Assertion failed: ${safeJoin(args.slice(1), ' ') || 'console.assert'}`; 
        
               breadcrumbData.data.extra.arguments = normalize(args.slice(1), 3); 
        
             } 
        
           } 
        
           Breadcrumbs.addBreadcrumb(breadcrumbData, { 
        
             input: args, 
        
             level, 
        
           });

You can see below how it looks in the UI. Makes you assume that it's a failed assertion:

Navigation Menu

Repository navigation

console.assert adds a breadcrumb even when assertion doesn't fail #2211

Package + Version

Version:

Description

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	if (level === 'assert') {
	if (args[0] === false) {
	breadcrumbData.message = `Assertion failed: ${safeJoin(args.slice(1), ' ') \|\| 'console.assert'}`;
	breadcrumbData.data.extra.arguments = normalize(args.slice(1), 3);
	}
	}

	Breadcrumbs.addBreadcrumb(breadcrumbData, {
	input: args,
	level,
	});

console.assert adds a breadcrumb even when assertion doesn't fail #2211

Description

Package + Version

Version:

Description

Activity

rchl commented on Aug 29, 2019

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions