Skip to content

fix(tanstack-router): Check for fromLocation existence before reporting pageload #18464

New issue
New issue
Closed
#18463
Closed
fix(tanstack-router): Check for fromLocation existence before reporting pageload#18464
#18463
Assignees
logaretm

Description

@github-actions
github-actions
bot
opened on Dec 10, 2025

Note

The pull request "fix(tanstack-router): Check for fromLocation existence before reporting pageload" was created by @logaretm but did not reference an issue. Therefore this issue was created for better visibility in external tools like Linear.

Bad condition which short circuits the web vitals from being reported, I included a test anyways even thought it doesn't reproduce it.

Activity

  1. github-actions
    assigned
    logaretm
    on Dec 10, 2025

  2. linear commented on Dec 10, 2025

    @linear
    linearBot
    on Dec 10, 2025 – with Linear

    JS-1288

  3. logaretm commented on Dec 10, 2025

    @logaretm
    logaretm
    on Dec 10, 2025
    Member

    duplicate of #18425 😠

  4. logaretm
    closed this as a duplicateof Core Web Vitals aren't reported when enabling Tanstack Router integration #18425 on Dec 10, 2025
  5. logaretm
    added a commit that references this issue on Dec 11, 2025

    fix(tanstack-router): Check for `fromLocation` existence before repor…

    5affac5
  6. logaretm
    closed this as completedin #18463on Dec 11, 2025

  7. github-actions commented on Dec 16, 2025

    @github-actions
    github-actionsBot
    on Dec 16, 2025 – with GitHub Actions
    ContributorAuthor

    A PR closing this issue has just been released 🚀

    This issue was referenced by PR #18463, which was included in the 10.31.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions