Repository navigation
withErrorBoundary create unnecessary rerenders #17183
Description
Is there an existing issue for this?
- I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
- I have reviewed the documentation https://docs.sentry.io/
- I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/react
SDK Version
8.55.0
Framework Version
8.55.0
Link to Sentry event
No response
Reproduction Example/SDK Setup
export const MyScreenWithFallback = Sentry.withErrorBoundary(MyScreen, {
fallback: FatalErrorFallback,
});Steps to Reproduce
- Run this with dummy components
Expected Result
MyScreenWithFallback does not rerender when props are identical.
Actual Result
MyScreenWithFallback rerenders everytime.
Workaround
export const MyScreenWithFallback = React.memo(Sentry.withErrorBoundary(MyScreen, {
fallback: FatalErrorFallback,
}));Real solution
function withErrorBoundary(
WrappedComponent,
errorBoundaryOptions,
) {
const componentDisplayName = WrappedComponent.displayName || WrappedComponent.name || UNKNOWN_COMPONENT;
const Wrapped = React.memo(((props) => React.createElement(ErrorBoundary, { ...errorBoundaryOptions,}
, React.createElement(WrappedComponent, { ...props,} )
)
));
Wrapped.displayName = `errorBoundary(${componentDisplayName})`;
// Copy over static methods from Wrapped component to Profiler HOC
// See: https://reactjs.org/docs/higher-order-components.html#static-methods-must-be-copied-over
hoistNonReactStatics(Wrapped, WrappedComponent);
return Wrapped;
}Metadata
Metadata
Assignees
Projects
- Status
Activity
linear commentedon Jul 28, 2025
JS-779 withErrorBoundary create unnecessary rerenders
chargome commentedon Jul 28, 2025
Hey @OoDeLally would you mind upgrading the SDK to the latest version and check if the issue persists?
OoDeLally commentedon Jul 28, 2025
Hello, thanks for your answer.
Unfortunately, I am using
@sentry/react-nativewhich has a fixed dependency on@sentry/react@8.55.0.However I had a look at
@sentry/react@9.42.0's dist, and the code looks the same as in8.55.0, so I assume the behavior would be the same.chargome commentedon Jul 28, 2025
@OoDeLally thanks for investigating – I'll have a look!
chargome commentedon Jul 28, 2025
Hey @OoDeLally I had a quick look at this. I did not encounter any unexpected re-renders (testing on react 19) – can you specify what you exactly mean with
Which props are you referring to?
OoDeLally commentedon Jul 29, 2025
I use why-did-you-render to monitor rerenderings:
Without
React.memo(...)With
React.memo.(...)The version with the
memo()is noticeably faster when switching screens.github-actions commentedon Jul 31, 2025
A PR closing this issue has just been released 🚀
This issue was referenced by PR #17230, which was included in the 10.0.0 release.