Skip to content

Convert @sentry/ember addon to V2 addon format #15835

Closed

Description

@johanrd

Problem Statement

Modern Ember build tools (@embroider/vite and @embroider/webpack) benefit greatly from static, pre-built addons when bundling the app.

The current @sentry/ember package is currently on the old ember addon-format. It works, but it is not optimized for the modern ember build tooling, as it does currently needs be processed/rewritten by @embroider on every build.

Also, it is currently sorted with warnings in the group of other legacy V1 addons when running e.g. npx ember-addon-v2-scanner@latest:

NPM Name Version Current version On V2 Addon V2 Addon available
'@sentry/ember' '9.9.0' '9.9.0' ❌ ❌

(related to #12336, but this is more specific)

Solution Brainstorm

Here is a guide for porting an addon to the V2 format .

Activity

  1. moved this to Waiting for: Product Owner in GitHub Issues with 👀 3on Mar 27, 2025
  2. added theissue type on Mar 27, 2025
  3. mydea commented on Mar 27, 2025

    @mydea
    Member

    Hey, thanks for opening this.

    We are currently pretty busy, so I can't really say when the team will find time to pick this up. We'd be happy to review a PR for this, though! A challenge would be that we have to remain compatible with the old format too - not sure if/how it is possible for us to publish both variants at the same time? If this is not possible in the same package, we can probably only make this change in the next major (v10), but work could be prepared for it already in advance.

  4. moved this from Waiting for: Product Owner to No status in GitHub Issues with 👀 3on Mar 27, 2025
  5. johanrd commented on Mar 27, 2025

    @johanrd
    Author

    @mydea ok, good. Yes, it would maybe considered a breaking change in some cases (but also maybe not for a simple addon like this?). The V2 addon format with @embroider/addon-shim provides backwards compatible support for classic builds.

  6. moved this to Waiting for: Product Owner in GitHub Issues with 👀 3on Mar 27, 2025
  7. mydea commented on Mar 27, 2025

    @mydea
    Member

    Basically, if current E2E tests using the Ember SDK pass, any change is fine 😅 (I believe). As long as compatibility remains given, we can always update! This means it has to support:

    Node 18+
    Ember 4+

    Which is our current support policy.

  8. moved this from Waiting for: Product Owner to No status in GitHub Issues with 👀 3on Mar 27, 2025
  9. johanrd commented on Mar 27, 2025

    @johanrd
    Author

    Ok, good. Backwards compatibility not be a problem then, as I believe the V2 addon format is supported by ember 3.28+.

  10. 70 remaining items

  11. moved this to Waiting for: Community in GitHub Issues with 👀 3on Nov 11, 2025
  12. moved this from Waiting for: Product Owner to No status in GitHub Issues with 👀 3on Nov 11, 2025
  13. getsantry commented on Dec 3, 2025

    @getsantry

    This issue has gone three weeks without activity. In another week, I will close it.

    But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


    "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

  14. RobbieTheWagner commented on Dec 3, 2025

    @RobbieTheWagner

    Could we remove the auto close stuff here please? We definitely intend to work on this eventually and would like to keep the issue open.

  15. moved this from Waiting for: Community to Waiting for: Product Owner in GitHub Issues with 👀 3on Dec 3, 2025
  16. chargome commented on Dec 3, 2025

    @chargome
    Member

    Removed it 👍

  17. moved this from Waiting for: Product Owner to No status in GitHub Issues with 👀 3on Dec 3, 2025
  18. nicohrubec commented on Sep 29, 2026

    @nicohrubec
    Member

    Implemented in #23252.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions