Skip to content

Rename Request type #14300

New issue
New issue
Closed
#14317
Closed
Rename Request type#14300
#14317
Assignees
mydea
Labels
Task

Description

@lforst
lforst
opened on Nov 14, 2024

Description

Our Request type should be renamed to not clash with the built-in type.

sentry-javascript/packages/types/src/request.ts

Lines 3 to 5 in f4c5900

* TODO(v9): Rename this to avoid confusion, because Request is also a native type.
*/
export interface Request {

Tasks:

  • Add alias for type (e.g. "SentryRequestData", "RequestContextData", TBD)
  • Deprecate old Request type

Activity

  1. lforst
    assigned
    mydea
    on Nov 15, 2024
  2. mydea
    closed this as completedin #14317on Nov 18, 2024
  3. mydea
    closed this as completedin ef83bfcon Nov 18, 2024
  4. lforst
    added a commit that references this issue on Nov 18, 2024

    ref(types): Deprecate `Request` type in favor of `RequestEventData` (#…

    ef83bfc

  5. github-actions commented on Nov 19, 2024

    @github-actions
    github-actionsBot
    on Nov 19, 2024 – with GitHub Actions
    Contributor

    A PR closing this issue has just been released 🚀

    This issue was referenced by PR #14317, which was included in the 8.39.0 release.

  6. onurtemizkan
    added a commit that references this issue on Nov 22, 2024

    ref(types): Deprecate `Request` type in favor of `RequestEventData` (#…

    1347c78
  7. ghost added
    Task
    on Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Task

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions