@sentry/astro breaks drizzle-orm in Astro

Is there an existing issue for this?

I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
I have reviewed the documentation https://docs.sentry.io/
I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/astro

SDK Version

8.17.0

Framework Version

Astro 4.11.5

Link to Sentry event

No response

SDK Setup/Reproduction Example

https://stackblitz.com/edit/github-yligk2?file=astro.config.mjs

Steps to Reproduce

Create a new blank Astro project.
Install @sentry/astro and drizzle-orm.
Create a src/middleware.ts file.
Import any operator from drizzle-orm:

import { or } from 'drizzle-orm';

Run the server and open the index page.
Receive error: MiddlewareCantBeLoaded because drizzle-orm has no export "or".

Expected Result

Pages should load as normal even if the middleware depends on drizzle-orm.

Actual Result

 astro  v4.11.5 ready in 415 ms

┃ Local    http://localhost:4321/
┃ Network  use --host to expose

24:59:05 watching for file changes...
24:59:15 [ERROR] [MiddlewareCantBeLoaded] An unknown error was thrown while loading your middleware.
  Error reference:
    https://docs.astro.build/en/reference/errors/middleware-cant-be-loaded/
  Stack trace:
    at /home/ibiyemi/projects/personal/rdvz-web/node_modules/astro/dist/core/middleware/loadMiddleware.js:8:24
    [...] See full stack trace in the browser, or rerun with --verbose.
  Caused by:
  [vite] The requested module 'drizzle-orm' does not provide an export named 'or'
    at analyzeImportedModDifference (file:///home/ibiyemi/projects/personal/rdvz-web/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:52533:15)
    at async ssrImport (file:///home/ibiyemi/projects/personal/rdvz-web/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:53392:16)
    at async instantiateModule (file:///home/ibiyemi/projects/personal/rdvz-web/node_modules/vite/dist/node/chunks/dep-CzJTQ5q7.js:53451:5)

Hello, thank you for writing in. I've tried reproducing this locally with an astro starter project and the steps outlined here but did not encounter the issue.

 astro  v4.11.5 ready in 86 ms

┃ Local    http://localhost:4321/
┃ Network  use --host to expose

09:38:15 watching for file changes...
[Function: or]

~~Could you please provide a sample repo or stackblitz?~~
Taking a look at the provided stackblitz :)

This looks to be some kind of issue with import in the middle and ESM. We are still investigating, but for now to get you unstuck you could create an empty sentry.server.config.js file. You won't get any server-side instrumentation, just client-side but at least it should let you run your app.

I suspect this is the same issue as seen here:
nodejs/import-in-the-middle#139

I've got an open PR to fix this:
nodejs/import-in-the-middle#140

@timfish

@timfish lol I just opened another issue in nodejs/import-in-the-middle#141 b/c I missed the connection to nodejs/import-in-the-middle#139 😅

@RIP21

@RIP21 I don't understand how you solved the issue. Can you give an example please? I'm not using a preload because I don't have any special hooks, but I would love to use one if it will let me add Sentry back into my application.

@laptou

@laptou inused include instead of exclude, including all the dependencies (excluding dev dependencies) I use except Drizzle-orm and it worked. Just doing exclude on Drizzle-orm didn't work out for me.

@timfish @mydea FYI, maybe it's also a problem, but I hope underlying issue will be solved so these include/exclude won't be needed (BTW which issues to subscribe to to track that?)

We are working on #13139, and will eventually look at using this by default, which will allow you to skip wrapping anything that we are not explicitly instrumenting, without having to define packages manually!

v8.29.0 of the Node SDK adds the new onlyIncludeInstrumentedModules option to registerEsmLoaderHooks.

import * as Sentry from '@sentry/node';

Sentry.init({
  dsn: '__PUBLIC_DSN__',
  registerEsmLoaderHooks: { onlyIncludeInstrumentedModules: true },
});

When set to true, import-in-the-middle will only wrap ESM modules that are specifically instrumented by OpenTelemetry plugins. This is useful to avoid issues where import-in-the-middle is not compatible with some of your dependencies.

This feature will only work if you Sentry.init() the SDK before the instrumented modules are loaded. This can be achieved via the Node --register and --import CLI flags or by loading your app code via async import() after calling Sentry.init().

Please let me know if this helps solve the import-in-the-middle incompatibility issues you are experiencing!

Closing this for clean-up. If this issue still applies, please re-open. Thanks!

Navigation Menu

Repository navigation

`@sentry/astro` breaks `drizzle-orm` in Astro #12912

Is there an existing issue for this?

How do you use Sentry?

Which SDK are you using?

SDK Version

Framework Version

Link to Sentry event

SDK Setup/Reproduction Example

Steps to Reproduce

Expected Result

Actual Result

53 remaining items

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

@sentry/astro breaks drizzle-orm in Astro #12912

Description

Is there an existing issue for this?

How do you use Sentry?

Which SDK are you using?

SDK Version

Framework Version

Link to Sentry event

SDK Setup/Reproduction Example

Steps to Reproduce

Expected Result

Actual Result

Activity

andreiborza commented on Jul 15, 2024

andreiborza commented on Jul 15, 2024

timfish commented on Jul 15, 2024

Lms24 commented on Jul 15, 2024

53 remaining items

laptou commented on Aug 7, 2024

RIP21 commented on Aug 7, 2024

mydea commented on Aug 8, 2024

timfish commented on Sep 9, 2024

AbhiPrasad commented on Nov 1, 2024

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

`@sentry/astro` breaks `drizzle-orm` in Astro #12912