Repository navigation
User Feedback submission failure is reflected as successful through the UI #12476
Description
Is there an existing issue for this?
- I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
- I have reviewed the documentation https://docs.sentry.io/
- I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/nextjs
SDK Version
8.9.1
Framework Version
Nextjs 14
Link to Sentry event
No response
SDK Setup
No response
Steps to Reproduce
- Opened Brave
- Navigated to website with User Feedback setup for Sentry
- Opened Dev Tools to inspect Network Requests
- I click the feedback button and complete all information, and click Send Bug Report
- The sentry HTTP request doesn't go through (understandable, as this is Brave)
- Regardless of the above , the UI thanks me for my feedback without showing any error
Prerequisites:
- The site is setup successfully to receive user feedback from other browsers, as when I use Chrome the feedback is received in my Sentry User Feedback page.
- Only the minimum setup was done for setting up User Feedback (i.e. not using any custom UI nor the User Feedback API).
Expected Result
I would expect an error to show, or at least I would expect a successful message not to show.
Actual Result
Success message on submission failure:
Failed HTTP request:
Reacted by Benjamin Staneck
Metadata
Metadata
Assignees
Projects
- Status
Activity
Lms24 commentedon Jun 13, 2024
Hi @suuf thanks for writing in! Unfortunately, Brave is know to block Sentry requests by default (see "Dealing with Ad Blockers" on this page). So I assume is that the browser blocks the request, especially given that it works in Chrome.
On first thought, I agree though that ideally, the feedback widget should show transparently that the feedback couldn't be sent. Unfortunately, there isn't really anything users could do in this specific case other than switching browsers.
On an implementation specific note: Our SDKs are generally designed to fail silently so that end users don't even notice a problem with the SDK (+ it shouldn't interrupt the application's behaviour). I think there might be a possibility to listen to failed requests (
Client.on('afterSendEvent')but not sure if this is applicable easily.Since I don't have much context on the feedback widget, I'll ask the feedback team to further look into this.
fix(feedback): Send feedback rejects invalid responses (#12518)
AbhiPrasad commentedon Jun 21, 2024
Fix released with https://github.com/getsentry/sentry-javascript/releases/tag/8.10.0!