Skip to content

Add protocol metadata to resource fetch requests #12395

Closed

Description

@serglom21

Problem Statement

Currently, information like network.protocol.name and network.protocol.version is added to http.client operations. It would be beneficial to also see this information on resource fetch requests

Solution Brainstorm

Add network.protocol.name and network.protocol.version to resource fetch requests

Activity

  1. moved this to Waiting for: Product Owner in GitHub Issues with 👀 3on Jun 6, 2024
  2. Lms24 commented on Jun 7, 2024

    @Lms24
    Member

    Hey @serglom21 thanks for writing in!

    It would be beneficial to also see this information on resource fetch requests

    To confirm, do you mean the browser resource.(script|img|other) spans?
    image

    I'm not sure this is possible given that the instrumentation for fetch and XHR requests (http.client spans) is different from how we create the resource spans. Gonna tag @k-fish since I believe you worked on adding the http timing data. Any idea if we can obtain this data for resource spans?

    Which SDK are you using?

  3. moved this from Waiting for: Product Owner to No status in GitHub Issues with 👀 3on Jun 7, 2024
  4. AbhiPrasad commented on Jun 7, 2024

    @AbhiPrasad
    Contributor

    Yes we can add this because it comes from the resource timing api:

    const { name, version } = extractNetworkProtocol(resourceTiming.nextHopProtocol);

  5. serglom21 commented on Jun 7, 2024

    @serglom21
    Author

    @Lms24 Correct! I mean all of the resource.(script|img|other) spans

    This was tested on sentry.javascript.react@7.69.0

  6. moved this to Waiting for: Product Owner in GitHub Issues with 👀 3on Jun 7, 2024
  7. moved this from Waiting for: Product Owner to No status in GitHub Issues with 👀 3on Jun 7, 2024
  8. k-fish commented on Jun 10, 2024

    @k-fish
    Member

    Ditto what @AbhiPrasad said, it's definitely possible to get that out since it's part of resource timing.

  9. self-assigned this
    on Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions