Repository navigation
Replay fails to start recording when using start() #11983
Description
Replays will fail to start recording when using start() specifically when manually recording and after the user has been idle for a long period of time. We need to reset the user activity state when we call start(), otherwise the session will be [incorrectly] considered to be idle and unable to send any replay events.
Reacted by Jasmin
Metadata
Metadata
Assignees
Labels
No labels
Activity
mydea commentedon May 13, 2024
So you mean, a session is ongoing, then you call
start()before the session has been invalidated? 🤔But this is overall not good, in this scenario you should always call
replay.isEnabled()and that would also returntruein this scenario, wouldn't it? In which case you def. should never callstart()!I guess what we could do is check for session expiration in
isEnabled()🤔 that would invalidate the session if it is disabled = but it would just create a new session and not stop it, so you still would not be able to callstart()again in this case!billyvg commentedon May 13, 2024
No this is before a session exists (e.g. manual recording).
fix(replay): Fix user activity not being updated in `start()`
fix(replay): Fix user activity not being updated in `start()` (#12001)
fix(replay/v7): Fix user activity not being updated in `start()`
billyvg commentedon May 13, 2024
Backport for v7 here
fix(replay): Fix user activity not being updated in `start()` (#12001)