Repository navigation
@sentry/aws-serverless Has No ESM Artifacts #11965
Description
Is there an existing issue for this?
- I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
- I have reviewed the documentation https://docs.sentry.io/
- I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/aws-serverless
SDK Version
8.0.0-rc.2
Framework Version
No response
Link to Sentry event
No response
SDK Setup
No response
Steps to Reproduce
- npm install @sentry/aws-serverless@8.0.0-rc.2
- Inspect installed
package.jsonto confirm moduleexports
"exports": {
"./package.json": "./package.json",
".": {
"import": {
"types": "./types/index.d.ts",
"default": "./esm/index.js"
},
"require": {
"types": "./types/index.d.ts",
"default": "./cjs/index.js"
}
},
- Look for the
./esmfolder in the root of the module
Expected Result
The ./esm folder to exist in the root of the module
Actual Result
What am I missing? I feel like I am doing something wrong...
Activity
jd-carroll commentedon May 9, 2024
I also just confirmed that the
esmoutput does not exist on 8.0.0-rc.1.It does exist in its counter parts like
@sentry/node&@sentry/core, so looking like just an issue withaws-serverless[-]8.0.0-rc.2 Regression No ESM[/-][+]@sentry/aws-serverless Does Not Support ESM[/+][-]@sentry/aws-serverless Does Not Support ESM[/-][+]@sentry/aws-serverless Has No ESM Artifacts[/+]Lms24 commentedon May 10, 2024
Hey @jd-carroll thanks for writing in! You're correct, we don't emit ESM artifacts in the
@sentry/aws-serverlesspackage at the moment.Based on #11052 this is intentional because the code in the package still relies on arequirecall which isn't compatible with pure ESM mode (requireis simplyundefinedin ESM mode).I think what we need to do for now is remove the respective
package.jsonentry to no longer point to non-existing files. I'll open a PR in a couple of minutes.Update: We actually should ship ESM code again because we removed the
requirecall I mentioned above. Thanks for jumping in @AbhiPrasad!I opened #11973 to ship ESM artifacts again. Thanks for reporting!
jd-carroll commentedon May 10, 2024
Amazing! Thank you ❤️
Any chance we could get an RC-3 by this evening? 😬