Support React 19 #11798

Activity

1. AbhiPrasad

   added

   Package: react

   on Apr 25, 2024
2. AbhiPrasad

   assigned

   AbhiPrasad

   and unassigned

   AbhiPrasad

   on Apr 25, 2024
3. AbhiPrasad

   self-assigned this

   on May 21, 2024
4. AbhiPrasad commented on May 22, 2024

   

   AbhiPrasad

   on May 22, 2024

   Last edited by AbhiPrasad

   ContributorAuthor

   More actions

   @rickhanlonii The API we're looking to implement for Sentry error monitoring is:

   import { reactErrorHandler } from '@sentry/react';
   import { hydrateRoot } from "react-dom/client";
   
   ReactDOM.hydrateRoot(
     document.getElementById("root") as HTMLElement,
     <React.StrictMode>
       <App />
     </React.StrictMode>,
     {
       onUncaughtError: Sentry.reactErrorHandler(),
       onCaughtError: Sentry.reactErrorHandler((error, errorInfo) => {
         // optional callback if users want more/custom config in addition?
       }),
     }
   );

   The only thing here is that if you set a onUncaughtError option, it overrides the default, which means you lose out on the dev mode logging:

   https://github.com/facebook/react/blob/3ac551e855f9bec3161da2fc8787958aa62113db/packages/react-reconciler/src/ReactFiberErrorLogger.js#L36-L51

   In this case there is no way for us to replicate the An error occurred in the <${componentName}> component: message (because componentName is private API), so asking users to add Sentry.reactErrorHandler degrades their local development experience.

   I guess we can tell users to only set this for production, but Sentry can also be used in development environments via Spotlight (Sentry for Development).

   Is there a way we can get access to the original onUncaughtError handler so we can execute that, while sending the error to Sentry at the same time?

   👍React with 👍2Reacted by Andrei and Francesco Gringl-Novy
5. AbhiPrasad commented on May 29, 2024

   

   AbhiPrasad

   on May 29, 2024

   ContributorAuthor

   More actions

   Released with https://github.com/getsentry/sentry-javascript/releases/tag/8.7.0!
6. AbhiPrasad

   closed this as completedon May 29, 2024