Repository navigation
Error logs are muted when using wrapRemixHandleError as a handleError function in Remix #11615
Description
Is there an existing issue for this?
- I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
- I have reviewed the documentation https://docs.sentry.io/
- I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases
How do you use Sentry?
Self-hosted/on-premise
Which SDK are you using?
@sentry/remix
SDK Version
7.110.0
Framework Version
No response
Link to Sentry event
No response
SDK Setup
Sentry.init({
dsn: process.env.SENTRY_REMIX_DSN,
environment: process.env.APP_ENV,
release: `itsme-b2b-portal-fe@${process.env.APP_VERSION}`,
tracesSampleRate: Number(process.env.SENTRY_SAMPLE_RATE),
initialScope: {
tags: {
'app.version': process.env.APP_VERSION,
'portal.version': process.env.B2B_PORTAL_VERSION,
},
},
});
Steps to Reproduce
- Add
export const handleError = Sentry.wrapRemixHandleErrorto yourentry.server.tsx - Throw a random server error (for instance
throw new Error('foo');in aloaderfunction) - Check the terminal console and find no message
fooin console.
Expected Result
I expect the node console to log foo
Actual Result
no foo message
Metadata
Metadata
Assignees
Projects
- Status
Activity
Lms24 commentedon Apr 16, 2024
Hey @thomasverleye thanks for writing in! I'm gonna ask @onurtemizkan to please take a look, thanks!
General note: Ideally, our SDK just grabs the error and sends it to Sentry. We generally always rethrow/pass down the error so that you can handle it yourself afterwards. In some cases, this a bit tricky or unavoidable slightly modifies the default behaviour (e.g. error message formatting in NodeJS). However, if we can, we should still rethrow the error (however that works for Remix specifically).
onurtemizkan commentedon Apr 25, 2024
Hey @thomasverleye, thanks for reporting.
When
handleErroris used, Remix disables the built-in error logging for the errors that end up inside that utility (Remix Docs) So, this seems like the expected Remix behaviour.That said, as @Lms24 mentioned, I also checked the other places we handle / report errors like
loader/action/documentRequest, and indeed we seem to be swallowing them. So I'll open a PR to fix that. That will probably fix the issue you have reported (as you're throwing error from theloader). But not all the errors that are handled bywrapRemixHandleError.